Attention is currently required from: Tarun Tuli, Chen-Tsung Hsieh, Tony Huang, Derek Huang.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74776 )
Change subject: mb/google/nissa/var/yavilla: Add elan touchscreen support
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/yavilla/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74776/comment/365a2b9c_6804d940
PS1, Line 168: register "stop_delay_ms" = "280"
wondering why stop need 280ms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74776
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2779c2930d89ff42233f9b20bd8abdf6dc00c0e0
Gerrit-Change-Number: 74776
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-CC: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 08:38:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment