Change in coreboot[master]: Puff: Enable VBOOT_EARLY_EC_SYNC

[Daisuke Nojiri (Code Review)]

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40390 )

Change subject: Puff: Enable VBOOT_EARLY_EC_SYNC
......................................................................

Puff: Enable VBOOT_EARLY_EC_SYNC

This patch enables CONFIG_EARLY_EC_SYNC and disables
CONFIG_VBOOT_EC_EFS. EFS2 will be done in romstage.

Signed-off-by: dnojiri

BUG=b/147298634, chromium:1045217
BRANCH=none
TEST=Verify software sync succeeds on Puff.

Change-Id: I8d7c25f8281496c7adb282f5d4e0fc192d746e3e
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/40390/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index ff3f6a4..62a5127 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -137,13 +137,13 @@
 config VBOOT
    select HAS_RECOVERY_MRC_CACHE
    select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
+	select VBOOT_EARLY_EC_SYNC

endif # BOARD_GOOGLE_BASEBOARD_HATCH

if BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP

config VBOOT
-	select VBOOT_EARLY_EC_SYNC
    select VBOOT_LID_SWITCH

endif # BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP
diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name
index ac64a9e..bcdf6db 100644
--- a/src/mainboard/google/hatch/Kconfig.name
+++ b/src/mainboard/google/hatch/Kconfig.name
@@ -72,7 +72,6 @@
    select BOARD_ROMSIZE_KB_32768
    select ROMSTAGE_SPD_SMBUS
    select SPD_READ_BY_WORD
-	select VBOOT_EC_EFS

config BOARD_GOOGLE_HELIOS_DISKSWAP
    bool "->  Helios_Diskswap"

[Daisuke Nojiri (Code Review)]

Hello build bot (Jenkins), Joel Kitching, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40390

to look at the new patch set (#2).

Change subject: Puff: Enable VBOOT_EARLY_EC_SYNC
......................................................................

Puff: Enable VBOOT_EARLY_EC_SYNC

This patch enables CONFIG_EARLY_EC_SYNC and disables
CONFIG_VBOOT_EC_EFS. EFS2 will be done in romstage.

BUG=b:147298634, chromium:1045217
BRANCH=none
TEST=Verify software sync succeeds on Puff.

Signed-off-by: dnojiri 
Change-Id: I8d7c25f8281496c7adb282f5d4e0fc192d746e3e
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/40390/2

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40390 )

Change subject: Puff: Enable VBOOT_EARLY_EC_SYNC
......................................................................

Patch Set 7: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40390 )

Change subject: Puff: Enable VBOOT_EARLY_EC_SYNC
......................................................................

Patch Set 7:

Shouldn't actually push this before the vboot change and uprev still needed (see discussion in CB:40389). Please make sure you actually test this on an affected device, too!

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40390 )

Change subject: Puff: Enable VBOOT_EARLY_EC_SYNC
......................................................................

Patch Set 9:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40390/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40390/9//COMMIT_MSG@2 
PS9, Line 2: dnojiri
Please configure your name.

$ git config --global user.name "Daisuke Nojiri"
    $ git commit --amend -s --author="Daisuke Nojiri "

https://review.coreboot.org/c/coreboot/+/40390/9//COMMIT_MSG@10 
PS9, Line 10: CONFIG_VBOOT_EC_EFS. EFS2 will be done in romstage.
Please add the justification/motivation.

https://review.coreboot.org/c/coreboot/+/40390/9//COMMIT_MSG@16 
PS9, Line 16: dnojiri
Ditto.

[Daisuke Nojiri (Code Review)]

Hello Shelley Chen, build bot (Jenkins), Joel Kitching, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40390

to look at the new patch set (#10).

Change subject: Puff: Enable VBOOT_EARLY_EC_SYNC
......................................................................

Puff: Enable VBOOT_EARLY_EC_SYNC

Romstage is now where software sync is performed for chromebooks.
EFS2 has been ported to romstage from Depthcharge. Puff should
follow.

This patch enables CONFIG_EARLY_EC_SYNC and disables
CONFIG_VBOOT_EC_EFS. EFS2 will be done in romstage.

BUG=b:147298634, chromium:1045217
BRANCH=none
TEST=Verify software sync succeeds on Puff.

Signed-off-by: Daisuke Nojiri 
Change-Id: I8d7c25f8281496c7adb282f5d4e0fc192d746e3e
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/40390/10

[Daisuke Nojiri (Code Review)]

Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40390 )

Change subject: Puff: Enable VBOOT_EARLY_EC_SYNC
......................................................................

Patch Set 10:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40390/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40390/9//COMMIT_MSG@2 
PS9, Line 2: dnojiri
> Please configure your name. […]

Done

https://review.coreboot.org/c/coreboot/+/40390/9//COMMIT_MSG@10 
PS9, Line 10: CONFIG_VBOOT_EC_EFS. EFS2 will be done in romstage.
> Please add the justification/motivation.

Done

https://review.coreboot.org/c/coreboot/+/40390/9//COMMIT_MSG@16 
PS9, Line 16: dnojiri
> Ditto.

Done

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40390 )

Change subject: Puff: Enable VBOOT_EARLY_EC_SYNC
......................................................................

Patch Set 11: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40390 )

Change subject: Puff: Enable VBOOT_EARLY_EC_SYNC
......................................................................

Puff: Enable VBOOT_EARLY_EC_SYNC

Romstage is now where software sync is performed for chromebooks.
EFS2 has been ported to romstage from Depthcharge. Puff should
follow.

This patch enables CONFIG_EARLY_EC_SYNC and disables
CONFIG_VBOOT_EC_EFS. EFS2 will be done in romstage.

BUG=b:147298634, chromium:1045217
BRANCH=none
TEST=Verify software sync succeeds on Puff.

Signed-off-by: Daisuke Nojiri 
Change-Id: I8d7c25f8281496c7adb282f5d4e0fc192d746e3e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40390
Reviewed-by: Julius Werner 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index b284ffe..11137bd 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -141,13 +141,13 @@
 config VBOOT
    select HAS_RECOVERY_MRC_CACHE
    select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
+	select VBOOT_EARLY_EC_SYNC

endif # BOARD_GOOGLE_BASEBOARD_HATCH

if BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP

config VBOOT
-	select VBOOT_EARLY_EC_SYNC
    select VBOOT_LID_SWITCH

endif # BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP
diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name
index 0713d13..de9bcb5 100644
--- a/src/mainboard/google/hatch/Kconfig.name
+++ b/src/mainboard/google/hatch/Kconfig.name
@@ -88,7 +88,6 @@
    select BOARD_ROMSIZE_KB_32768
    select ROMSTAGE_SPD_SMBUS
    select SPD_READ_BY_WORD
-	select VBOOT_EC_EFS

config BOARD_GOOGLE_HELIOS_DISKSWAP
    bool "->  Helios_Diskswap"