Change in coreboot[master]: ec/google/chromeec: Add code for KEY_MICMUTE and KEY_KBDILLUMTOGGLE - coreboot-gerrit

31 Jul 2021


      Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56710 )
Change subject: ec/google/chromeec: Add code for KEY_MICMUTE and KEY_KBDILLUMTOGGLE
......................................................................
Patch Set 4:
(1 comment)
File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/56710/comment/739c06b9_2db2eade 
PS1, Line 6334: TK_KBDILLUMTOGGLE = 18,
              : 	TK_MICMUTE = 19,
...
The enum values here and in the EC CL do not match.
Done. chromeec/ec_commands.h and platform/ec/include/ec_commands.h are aligned now.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56710
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4fa3e627f448265f72279704d258b2d3fe8fc17
Gerrit-Change-Number: 56710
Gerrit-PatchSet: 4
Gerrit-Owner: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Rajat Jain rajatja@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Sat, 31 Jul 2021 13:05:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment