Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43250 )
Change subject: drivers/ti/tps65090: Drop dead code ......................................................................
drivers/ti/tps65090: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Iebd9080cd0e859dce5e6c5398429c38d1aa075dc Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/ti/tps65090/tps65090.c 1 file changed, 0 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/43250/1
diff --git a/src/drivers/ti/tps65090/tps65090.c b/src/drivers/ti/tps65090/tps65090.c index 4f9005b..2d2ea69 100644 --- a/src/drivers/ti/tps65090/tps65090.c +++ b/src/drivers/ti/tps65090/tps65090.c @@ -92,48 +92,6 @@ return FET_ERR_NOT_READY; }
-/* FIXME(dhendrix): add timer API */ -#if 0 -int tps65090_fet_enable(unsigned int bus, enum fet_id fet_id) -{ - int loops; - unsigned long start; - int ret = 0; - - start = get_timer(0); - for (loops = 0; ; loops++) { - ret = tps65090_fet_set(bus, fet_id, 1); - if (!ret) - break; - - if (get_timer(start) > 100) - break; - - /* Turn it off and try again until we time out */ - tps65090_fet_set(bus, fet_id, 0); - } - - if (ret) { - printk(BIOS_DEBUG, "%s: FET%d failed to power on: time=%lums, " - "loops=%d\n", __func__, fet_id, - get_timer(start), loops); - } else if (loops) { - printk(BIOS_DEBUG, "%s: FET%d powered on after %lums, " - "loops=%d\n", __func__, fet_id, - get_timer(start), loops); - } - /* - * Unfortunately, there are some conditions where the power - * good bit will be 0, but the fet still comes up. One such - * case occurs with the lcd backlight. We'll just return 0 here - * and assume that the fet will eventually come up. - */ - if (ret == FET_ERR_NOT_READY) - ret = 0; - - return ret; -} -#endif int tps65090_fet_enable(unsigned int bus, enum fet_id fet_id) { int loops;
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43250 )
Change subject: drivers/ti/tps65090: Drop dead code ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43250 )
Change subject: drivers/ti/tps65090: Drop dead code ......................................................................
drivers/ti/tps65090: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Iebd9080cd0e859dce5e6c5398429c38d1aa075dc Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43250 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner --- M src/drivers/ti/tps65090/tps65090.c 1 file changed, 0 insertions(+), 42 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/drivers/ti/tps65090/tps65090.c b/src/drivers/ti/tps65090/tps65090.c index 4f9005b..2d2ea69 100644 --- a/src/drivers/ti/tps65090/tps65090.c +++ b/src/drivers/ti/tps65090/tps65090.c @@ -92,48 +92,6 @@ return FET_ERR_NOT_READY; }
-/* FIXME(dhendrix): add timer API */ -#if 0 -int tps65090_fet_enable(unsigned int bus, enum fet_id fet_id) -{ - int loops; - unsigned long start; - int ret = 0; - - start = get_timer(0); - for (loops = 0; ; loops++) { - ret = tps65090_fet_set(bus, fet_id, 1); - if (!ret) - break; - - if (get_timer(start) > 100) - break; - - /* Turn it off and try again until we time out */ - tps65090_fet_set(bus, fet_id, 0); - } - - if (ret) { - printk(BIOS_DEBUG, "%s: FET%d failed to power on: time=%lums, " - "loops=%d\n", __func__, fet_id, - get_timer(start), loops); - } else if (loops) { - printk(BIOS_DEBUG, "%s: FET%d powered on after %lums, " - "loops=%d\n", __func__, fet_id, - get_timer(start), loops); - } - /* - * Unfortunately, there are some conditions where the power - * good bit will be 0, but the fet still comes up. One such - * case occurs with the lcd backlight. We'll just return 0 here - * and assume that the fet will eventually come up. - */ - if (ret == FET_ERR_NOT_READY) - ret = 0; - - return ret; -} -#endif int tps65090_fet_enable(unsigned int bus, enum fet_id fet_id) { int loops;