Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43174 )
Change subject: sb/intel/i82801gx: Remove nic.c driver ......................................................................
sb/intel/i82801gx: Remove nic.c driver
It does nothing special, so why have it in the first place?
Change-Id: I27aff0ed67e9c69ab78050d35b49f6e26924d31a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/i82801gx/Makefile.inc D src/southbridge/intel/i82801gx/nic.c 2 files changed, 0 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/43174/1
diff --git a/src/southbridge/intel/i82801gx/Makefile.inc b/src/southbridge/intel/i82801gx/Makefile.inc index 3e48fff..1630f93 100644 --- a/src/southbridge/intel/i82801gx/Makefile.inc +++ b/src/southbridge/intel/i82801gx/Makefile.inc @@ -11,7 +11,6 @@ ramstage-y += azalia.c ramstage-y += ide.c ramstage-y += lpc.c -ramstage-y += nic.c ramstage-y += pci.c ramstage-y += pcie.c ramstage-y += sata.c diff --git a/src/southbridge/intel/i82801gx/nic.c b/src/southbridge/intel/i82801gx/nic.c deleted file mode 100644 index b9dcd31..0000000 --- a/src/southbridge/intel/i82801gx/nic.c +++ /dev/null @@ -1,28 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* This code should work for all ICH* southbridges with a NIC. */ - -#include <device/device.h> -#include <device/pci.h> -#include <device/pci_ids.h> - -static void nic_init(struct device *dev) -{ - /* Nothing yet */ -} - -static struct device_operations nic_ops = { - .read_resources = pci_dev_read_resources, - .set_resources = pci_dev_set_resources, - .enable_resources = pci_dev_enable_resources, - .init = nic_init, -}; - -/* 82801GB/GR/GDH/GBM/GHM (ICH7/ICH7R/ICH7DH/ICH7-M/ICH7-M DH) */ -/* Note: 82801GU (ICH7-U) doesn't have a NIC. */ -/* PCI ID loaded from EEPROM. If EEPROM is 0, 0x27dc is used. */ -static const struct pci_driver i82801gx_nic __pci_driver = { - .ops = &nic_ops, - .vendor = PCI_VENDOR_ID_INTEL, - .device = 0x27dc, -};
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43174 )
Change subject: sb/intel/i82801gx: Remove nic.c driver ......................................................................
Patch Set 1: Code-Review+2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43174 )
Change subject: sb/intel/i82801gx: Remove nic.c driver ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43174 )
Change subject: sb/intel/i82801gx: Remove nic.c driver ......................................................................
Patch Set 2: Code-Review+2
I don't think we have a board using the ICH7 NIC (it's a child on the 1E.0 PCI bridge iirc) in the tree. Maybe it needs special code, but NOOP code is not going to help that.
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43174 )
Change subject: sb/intel/i82801gx: Remove nic.c driver ......................................................................
sb/intel/i82801gx: Remove nic.c driver
It does nothing special, so why have it in the first place?
Change-Id: I27aff0ed67e9c69ab78050d35b49f6e26924d31a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43174 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Christian Walter christian.walter@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/i82801gx/Makefile.inc D src/southbridge/intel/i82801gx/nic.c 2 files changed, 0 insertions(+), 29 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Frans Hendriks: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/src/southbridge/intel/i82801gx/Makefile.inc b/src/southbridge/intel/i82801gx/Makefile.inc index 3e48fff..1630f93 100644 --- a/src/southbridge/intel/i82801gx/Makefile.inc +++ b/src/southbridge/intel/i82801gx/Makefile.inc @@ -11,7 +11,6 @@ ramstage-y += azalia.c ramstage-y += ide.c ramstage-y += lpc.c -ramstage-y += nic.c ramstage-y += pci.c ramstage-y += pcie.c ramstage-y += sata.c diff --git a/src/southbridge/intel/i82801gx/nic.c b/src/southbridge/intel/i82801gx/nic.c deleted file mode 100644 index b9dcd31..0000000 --- a/src/southbridge/intel/i82801gx/nic.c +++ /dev/null @@ -1,28 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* This code should work for all ICH* southbridges with a NIC. */ - -#include <device/device.h> -#include <device/pci.h> -#include <device/pci_ids.h> - -static void nic_init(struct device *dev) -{ - /* Nothing yet */ -} - -static struct device_operations nic_ops = { - .read_resources = pci_dev_read_resources, - .set_resources = pci_dev_set_resources, - .enable_resources = pci_dev_enable_resources, - .init = nic_init, -}; - -/* 82801GB/GR/GDH/GBM/GHM (ICH7/ICH7R/ICH7DH/ICH7-M/ICH7-M DH) */ -/* Note: 82801GU (ICH7-U) doesn't have a NIC. */ -/* PCI ID loaded from EEPROM. If EEPROM is 0, 0x27dc is used. */ -static const struct pci_driver i82801gx_nic __pci_driver = { - .ops = &nic_ops, - .vendor = PCI_VENDOR_ID_INTEL, - .device = 0x27dc, -};
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Christian Walter (Code Review)
-
Frans Hendriks (Code Review)