Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44525 )
Change subject: mb/google/dedede/var/magolor: Enable Audio ......................................................................
mb/google/dedede/var/magolor: Enable Audio
1. Enable HDA Pci device in devicetree 2. Enable I2C4 in devicetree and fill ACPI information 3. Pass correct IRQ GPIO for headset jack
BUG=None BRANCH=None TEST=Audio playback and recording works on Magolor DUT.
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: I38e2ff9b4b89dccc4c538773d15fd67d20bc895e --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/44525/1
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index 404024b..9d6598a 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -37,6 +37,31 @@ }"
device domain 0 on - device pci 15.0 on end + device pci 19.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Realtek RT5682"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)" + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP L"" + register "uid" = "0" + device i2c 28 on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP R"" + register "uid" = "1" + device i2c 29 on end + end + end + device pci 1f.3 on end # Intel HDA end end
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44525 )
Change subject: mb/google/dedede/var/magolor: Enable Audio ......................................................................
Patch Set 1: Code-Review+1
Ren Kuo has removed Marco Chen from this change. ( https://review.coreboot.org/c/coreboot/+/44525 )
Change subject: mb/google/dedede/var/magolor: Enable Audio ......................................................................
Removed reviewer Marco Chen.
Ren Kuo has removed Henry Sun from this change. ( https://review.coreboot.org/c/coreboot/+/44525 )
Change subject: mb/google/dedede/var/magolor: Enable Audio ......................................................................
Removed reviewer Henry Sun.
Ren Kuo has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44525 )
Change subject: mb/google/dedede/var/magolor: Enable Audio ......................................................................
Abandoned
replace it with another cl