Attention is currently required from: Furquan Shaikh, Angel Pons, Marco Chen, Karthik Ramasubramanian.
Vitaly Rodionov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52981 )
Change subject: drivers/i2c/cs42l42: Make HS_BIAS_SENSE_EN optional
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/i2c/cs42l42/chip.h:
https://review.coreboot.org/c/coreboot/+/52981/comment/0f95ae4f_c49ed928
PS4, Line 118: Default =
In this case, coreboot will always generate the property, so the kernel default is meaningless.
Yes, you are right. We need to add this property only when we want to disable it.
https://review.coreboot.org/c/coreboot/+/52981/comment/bb212436_0571b917
PS4, Line 118: Default =
In this case, coreboot will always generate the property, so the kernel default is meaningless.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52981
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87c6f01af1bdb5b1cb8e399191519598d7fbe9ea
Gerrit-Change-Number: 52981
Gerrit-PatchSet: 4
Gerrit-Owner: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 10 May 2021 22:15:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment