Change in coreboot[master]: util/bucts: Add tool to manipulate BUC.TS bit on Intel targets
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18224 )
Change subject: util/bucts: Add tool to manipulate BUC.TS bit on Intel targets ......................................................................
Patch Set 6:
(12 comments)
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c File util/bucts/bucts.c:
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@265 PS6, Line 265: ? "set, changing top swap not possible" : "unset, changing top swap is possible"); line over 80 characters
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@266 PS6, Line 266: printf("Top Swap : %s\n", ts ? "Enabled" : "Disabled"); line over 80 characters
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@269 PS6, Line 269: printf("Ranges swapped : 0x%llx-0x%08llx <-> 0x%08llx-0x%08llx", line over 80 characters
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@292 PS6, Line 292: printf("BIOS Interface Lock-Down set, Changing Top Swap not possible.\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@345 PS6, Line 345: printf("Invalid setting: multiple set/unset arguments\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@349 PS6, Line 349: printf("Print and Set are mutually exclusive!\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@357 PS6, Line 357: printf("Invalid setting: multiple set/unset arguments\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@361 PS6, Line 361: printf("Print and Set are mutually exclusive!\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@369 PS6, Line 369: printf("Print and Set are mutually exclusive!\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@378 PS6, Line 378: default: Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@392 PS6, Line 392: if ((io_fd = open("/dev/io", O_RDWR)) < 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@402 PS6, Line 402: if ((fd_mem = open(MEM_DEV, O_RDWR | O_SYNC)) == -1) { do not use assignment in if condition
-
build bot (Jenkins) (Code Review)