Attention is currently required from: Matt DeVillier, Angel Pons, Keith Hui.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72496 )
Change subject: nb/intel/snb/raminit_mrc.c: Provide default for hook ......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72496/comment/11230aff_a4205e14 PS7, Line 9: Of the 13 mainboards that implement mainboard_should_reset_usb() hook, : only samsung/stumpy does things differently. Turn the majority : implementation into a __weak default that this one board will override.
I do. looking at Stumpy's implementation and the comments, we may be able to drop it since the WA was likely for a 2.x ChromeOS kernel. Want me to test with using the common implementation?
The option on stumpy is basically the same except there is a CMOS option to change the behavior using legacy cmos_read/write without there being a way to set it with nvramtool. It's safe to say it was never used so that's why I'm suggesting to simply drop it in favor of a common !s3resume.
-
Arthur Heymans (Code Review)