Attention is currently required from: Felix Singer, Jamie Ryu, Wonkyu Kim, Subrata Banik, Ethan Tsao, Paul Menzel, Angel Pons, Raj Astekar, Ravishankar Sarawadi. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62772 )
Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till bootblock ......................................................................
Patch Set 8:
(13 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62772/comment/0b906848_e0cd807b PS4, Line 16:
Please mention that in the commit message.
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/62772/comment/361b15c0_be12571f PS5, Line 17: Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.corp-partner.google.com
Add a TEST= line? If you already have messages, please paste some of them, or at least mention the b […]
Done
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/62772/comment/8038a889_e0f210da PS7, Line 56: ifd2
Why not "mtl" instead? ifdtool seems to know about it.
Done
File src/soc/intel/meteorlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/4bb5c273_68ba6208 PS5, Line 14: include <intelblocks/ioc.h>
Done
File src/soc/intel/meteorlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/2e4ad270_bc562e11 PS7, Line 85: */
nit: add space before comment end
Done
https://review.coreboot.org/c/coreboot/+/62772/comment/7f02c942_ca4c9d47 PS7, Line 85: */
nit: add space before comment end
Done
File src/soc/intel/meteorlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/d434c4de_abef871b PS5, Line 35: pch_table[] = { : { PCI_DID_INTEL_MTL_ESPI_0, "Meteorlake SOC" }, : { PCI_DID_INTEL_MTL_ESPI_1, "Meteorlake SOC" }, : { PCI_DID_INTEL_MTL_ESPI_2, "Meteorlake SOC" }, : { PCI_DID_INTEL_MTL_ESPI_3, "Meteorlake SOC" }, : { PCI_DID_INTEL_MTL_ESPI_4, "Meteorlake SOC" }, : { PCI_DID_INTEL_MTL_ESPI_5, "Meteorlake SOC" }, : { PCI_DID_INTEL_MTL_ESPI_6, "Meteorlake SOC" }, : { PCI_DID_INTEL_MTL_ESPI_7, "Meteorlake SOC" },
This will have different SKU info string. […]
Done
File src/soc/intel/meteorlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/2dce80a5_0fb46a0c PS7, Line 27: MeteorLake
Hmmm, the other entries spell "Meteorlake" with the 'l' in lowercase. […]
"MeteorLake"
File src/soc/intel/meteorlake/include/soc/espi.h:
https://review.coreboot.org/c/coreboot/+/62772/comment/abb80475_5b4f45e8 PS7, Line 17: */
nit: Add space before comment end
Done
https://review.coreboot.org/c/coreboot/+/62772/comment/e33434f1_b52ff014 PS7, Line 18: */
nit: Add space before comment end
Done
File src/soc/intel/meteorlake/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/62772/comment/c90c4e9e_92903176 PS7, Line 73: /* : #define PID_IOM 0xAA : #define IOM_BASE_ADDR (IOE_PCR_ABOVE_4G_BASE_ADDR + (PID_IOM << 16)) : */
Why is this commented out?
Done
File src/soc/intel/meteorlake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/62772/comment/c6111fd5_c17af656 PS7, Line 11: pcidev_path_on_root_debug
Could we please use `pcidev_path_on_root` instead?
Done
https://review.coreboot.org/c/coreboot/+/62772/comment/8f7d1639_c3d07e3e PS7, Line 59: #define PCI_DEV_SLOT_GNA 0x08 : #define PCI_DEVFN_GNA _PCI_DEVFN(GNA, 0) : #define PCI_DEV_GNA _PCI_DEV(GNA, 0)
nit: Move above `PCI_DEV_SLOT_TCSS` to keep ordering?
Done