Change in coreboot[master]: console: Make DEFAULT_CONSOLE_LOGLEVEL available for CONSOLE_OVERRIDE...

[Johnny Lin (Code Review)]

Johnny Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45866 )

Change subject: console: Make DEFAULT_CONSOLE_LOGLEVEL available for CONSOLE_OVERRIDE_LOGLEVEL
......................................................................

console: Make DEFAULT_CONSOLE_LOGLEVEL available for CONSOLE_OVERRIDE_LOGLEVEL

It's more flexible to be able to keep using DEFAULT_CONSOLE_LOGLEVEL
when CONSOLE_OVERRIDE_LOGLEVEL is selected.

Change-Id: Ib3ca8482459584e039a0e8881d79358948696ac2
Signed-off-by: Johnny Lin 
---
M src/console/Kconfig
1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/45866/1

diff --git a/src/console/Kconfig b/src/console/Kconfig
index bad6c56..28138b3 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -315,8 +315,6 @@
      Set to "y" when the platform overrides the loglevel by providing
      a get_console_loglevel routine.

-if !CONSOLE_OVERRIDE_LOGLEVEL
-
 choice
    prompt "Default console log level"
    default DEFAULT_CONSOLE_LOGLEVEL_8 if CHROMEOS
@@ -375,8 +373,6 @@
    help
      Map the log level config names to an integer.

-endif
-
 config NO_POST
    bool "Don't show any POST codes"
    default n

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45866 )

Change subject: console: Make DEFAULT_CONSOLE_LOGLEVEL available for CONSOLE_OVERRIDE_LOGLEVEL
......................................................................

Patch Set 1:

CB:45771 and related changes provide another option under discussion, in the meantime this change and CB:45326 are based on the current design that can have a quick fix for the needed feature getting merged.

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45866 )

Change subject: console: Make DEFAULT_CONSOLE_LOGLEVEL available for CONSOLE_OVERRIDE_LOGLEVEL
......................................................................

Patch Set 3: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45866 )

Change subject: console: Make DEFAULT_CONSOLE_LOGLEVEL available for CONSOLE_OVERRIDE_LOGLEVEL
......................................................................

Patch Set 3: Code-Review-1

IIRC, the purpose of this Kconfig was exactly to hide
the loglevel prompt.

[Johnny Lin (Code Review)]

Johnny Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45866 )

Change subject: console: Make DEFAULT_CONSOLE_LOGLEVEL available for CONSOLE_OVERRIDE_LOGLEVEL
......................................................................

Abandoned

I see, they should be mutually exclusive to avoid confusion.