Attention is currently required from: Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78221?usp=email )
Change subject: soc/amd/genoa: Add SMI support
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/genoa/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/78221/comment/8b775285_14af12b9 :
PS1, Line 26: #define SMITYPE_G_GENINT2_L 1
this table doesn't seem to be updated for genoa yet; this entry should for example be
#define SMITYPE_G_AGPIO115_L 1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78221?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I491f4075cef8976e4b0762752c9e2e3c2ef886d5
Gerrit-Change-Number: 78221
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Comment-Date: Thu, 05 Oct 2023 21:45:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment