Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc support ......................................................................
soc/intel/tigerlake: Add Jasperlake soc support
Add Kconfig option for Jasperlake soc and make tigerlake as a base soc. This will allow us to differentiate between soc features.
Change-Id: Id5001dc498a7d7d5c7903dc3a3762da740fc9c8e Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/37112/1
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 2824e52..364d573 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -1,9 +1,19 @@ +config SOC_INTEL_TIGERLAKE_BASE + bool + config SOC_INTEL_TIGERLAKE bool + select SOC_INTEL_TIGERLAKE_BASE help Intel Tigerlake support
-if SOC_INTEL_TIGERLAKE +config SOC_INTEL_JASPERLAKE + bool + select SOC_INTEL_TIGERLAKE_BASE + help + Intel Jasperlake support + +if SOC_INTEL_TIGERLAKE_BASE
config CPU_SPECIFIC_OPTIONS def_bool y
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37112
to look at the new patch set (#2).
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
soc/intel/tigerlake: Add Jasperlake soc Kconfig
Add Kconfig option for Jasperlake soc and make tigerlake as a base soc. This will allow us to differentiate between soc features.
Change-Id: Id5001dc498a7d7d5c7903dc3a3762da740fc9c8e Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/37112/2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... PS2, Line 10: SOC_INTEL_JASPERLAKE can we also , select PCH_N_BASE from Jasperlake and PCH_BASE for tgl. This one has to be based on PCH common CL then.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... PS2, Line 10: SOC_INTEL_JASPERLAKE
can we also , select PCH_N_BASE from Jasperlake and PCH_BASE for tgl. […]
hows that even relevant to say N_BASE or just BASE? Do we expected to see any delta in code based on that, else it just a confusion and matter of curiosity
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... PS2, Line 10: SOC_INTEL_JASPERLAKE
hows that even relevant to say N_BASE or just BASE? […]
Not all PCH IPs under PCH_BASE apply for JSL
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 2: Code-Review+1
i'm good with this CL
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... PS2, Line 10: SOC_INTEL_JASPERLAKE
Not all PCH IPs under PCH_BASE apply for JSL
Mostly it won't be required Aamir. If we need, I'll create a new Kconfig in intel/common/pch and then push a new patch with proper changes.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... PS2, Line 10: SOC_INTEL_JASPERLAKE
Not all PCH IPs under PCH_BASE apply for JSL
Ok. I too checked again the PCH base does apply to JSL
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37112/2/src/soc/intel/tigerlake/Kco... PS2, Line 10: SOC_INTEL_JASPERLAKE
Ok. […]
Done
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 2: Code-Review+2
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
soc/intel/tigerlake: Add Jasperlake soc Kconfig
Add Kconfig option for Jasperlake soc and make tigerlake as a base soc. This will allow us to differentiate between soc features.
Change-Id: Id5001dc498a7d7d5c7903dc3a3762da740fc9c8e Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37112 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 11 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Aamir Bohra: Looks good to me, approved Ronak Kanabar: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 9c5fc98..01ce7d8 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -1,9 +1,19 @@ +config SOC_INTEL_TIGERLAKE_BASE + bool + config SOC_INTEL_TIGERLAKE bool + select SOC_INTEL_TIGERLAKE_BASE help Intel Tigerlake support
-if SOC_INTEL_TIGERLAKE +config SOC_INTEL_JASPERLAKE + bool + select SOC_INTEL_TIGERLAKE_BASE + help + Intel Jasperlake support + +if SOC_INTEL_TIGERLAKE_BASE
config CPU_SPECIFIC_OPTIONS def_bool y
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37112 )
Change subject: soc/intel/tigerlake: Add Jasperlake soc Kconfig ......................................................................
Patch Set 3:
(1 comment)
I think it would be beneficial in the future to add stub mainboards just to get some of this buildtested which is an essential part of QA.
https://review.coreboot.org/c/coreboot/+/37112/3/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37112/3/src/soc/intel/tigerlake/Kco... PS3, Line 1: SOC_INTEL_TIGERLAKE_BASE you didn't update the Makefile.inc for this...
-
Aamir Bohra (Code Review) -
Arthur Heymans (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)
-
Ronak Kanabar (Code Review)
-
Subrata Banik (Code Review)