Attention is currently required from: Tarun Tuli, John Zhao, Kapil Porwal, Tim Wawrzynczak, Sumeet R Pawnikar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67789 )
Change subject: soc/intel/meteorlake: Provide mitigation support for CNVi RFI
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/meteorlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/67789/comment/3609a82e_8ce6c505
PS7, Line 289: fill_fspm_audio_params,
: fill_fspm_cnvi_params,
: fill_fspm_cpu_params,
: fill_fspm_igd_params,
: fill_fspm_ipu_params,
: fill_fspm_ish_params,
: fill_fspm_misc_params,
: fill_fspm_mrc_params,
: fill_fspm_pcie_rp_params,
: fill_fspm_security_params,
: fill_fspm_smbus_params,
: fill_fspm_tcss_params,
: fill_fspm_trace_params,
: fill_fspm_uart_params,
: fill_fspm_usb4_params,
: fill_fspm_vtd_params,
Done
I request you not to take the alphabetically modification in the same CL. As there is no such rule that function calling has to be alphabetically ordered.
Please just keep this CL meaningful.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87110bc10b98a27a8f274680597b15a1df488824
Gerrit-Change-Number: 67789
Gerrit-PatchSet: 8
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 16:29:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Gerrit-MessageType: comment