Attention is currently required from: Cliff Huang, Jérémy Compostella, Lance Zhao, Lean Sheng Tan, Shuo Liu, Subrata Banik, Tim Wawrzynczak, yuchi.chen@intel.com.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85226?usp=email )
Change subject: arch/x86: Enable support for IOAPIC devices
......................................................................
Patch Set 4:
(2 comments)
File src/acpi/acpi_apic.c:
https://review.coreboot.org/c/coreboot/+/85226/comment/4bd94b7e_53416e37?usp... :
PS2, Line 244: assert(!CONFIG(ACPI_COMMON_MADT_IOAPIC) || dev->path.ioapic.gsi_base != 0);
Should we have a comment here to indicate the IOAPIC gsi0 don't need to have a devicetree object? Or […]
Done
File src/arch/x86/ioapic.c:
https://review.coreboot.org/c/coreboot/+/85226/comment/d2f08ccd_ba25982b?usp... :
PS1, Line 190: struct device dummy;
What about using `struct device_path path = {0};` instead ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85226?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie13d4f5c4f0704f0935974f90e5b7cf24e94aab3
Gerrit-Change-Number: 85226
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 04 Dec 2024 11:24:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com