Attention is currently required from: Paul Menzel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62827 )
Change subject: lib/cbfs: Compare addresses instead of arrays ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Can we just set -Wno-array-compare instead? There's nothing illegal about that expression and as we can see in this case, there are perfectly reasonable cases where you might want to do something like that. On the other hand, I don't really see a realistic scenario where this warning could prevent a real problem (anyone who doesn't know that `array1 == array2` doesn't compare the array elements in C shouldn't have any business submitting code to coreboot).
-
Julius Werner (Code Review)