Attention is currently required from: Felix Held, Fred Reitberger, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81225?usp=email )
Change subject: amdfwtool: Move the address of tables to the context
......................................................................
Patch Set 4:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/81225/comment/69f0c33e_2a83b90a :
PS3, Line 1640: ctx.pspdir = NULL;
: ctx.pspdir2 = NULL;
: ctx.pspdir2_b = NULL;
: ctx.biosdir = NULL;
: ctx.biosdir2 = NULL;
: ctx.biosdir2_b = NULL;
: ctx.ish_a_dir = NULL;
: ctx.ish_b_dir = NULL;
i'd move those directly before the if (cb_config.use_combo && combo_index > 0). […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81225?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I98b7d01e32c75b4f13e23d496cd3de3da900678d
Gerrit-Change-Number: 81225
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 19 Mar 2024 03:26:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment