Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37625 )
Change subject: mb/lenovo/t410: Add ricoh driver ......................................................................
mb/lenovo/t410: Add ricoh driver
Fix for CB:35086. Build the Ricoh SDcard driver that is defined in devicetree.
Change-Id: Ib0ac3da088d798c35e2c5ea045ea721c89d9e12f Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/lenovo/t410/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/37625/1
diff --git a/src/mainboard/lenovo/t410/Kconfig b/src/mainboard/lenovo/t410/Kconfig index 943bf43..f97a093 100644 --- a/src/mainboard/lenovo/t410/Kconfig +++ b/src/mainboard/lenovo/t410/Kconfig @@ -22,6 +22,7 @@ select MAINBOARD_USES_IFD_GBE_REGION select H8_HAS_BAT_TRESHOLDS_IMPL select MAINBOARD_HAS_LIBGFXINIT + select DRIVERS_RICOH_RCE822
config VBOOT select VBOOT_VBNV_CMOS
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37625 )
Change subject: mb/lenovo/t410: Add ricoh driver ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37625/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37625/1//COMMIT_MSG@7 PS1, Line 7: Add Select?
*Add* could also mean implement, so *select* might be more clear.
Patrick Rudolph has uploaded a new patch set (#2) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/37625 )
Change subject: mb/lenovo/t410: Select ricoh driver ......................................................................
mb/lenovo/t410: Select ricoh driver
Fix for CB:35086. Build the Ricoh SDcard driver that is defined in devicetree.
Change-Id: Ib0ac3da088d798c35e2c5ea045ea721c89d9e12f Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/lenovo/t410/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/37625/2
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37625 )
Change subject: mb/lenovo/t410: Select ricoh driver ......................................................................
Patch Set 2: Code-Review+2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37625 )
Change subject: mb/lenovo/t410: Select ricoh driver ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37625/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37625/1//COMMIT_MSG@7 PS1, Line 7: Add
Select? […]
Done
Philipp Deppenwiese has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37625 )
Change subject: mb/lenovo/t410: Select ricoh driver ......................................................................
mb/lenovo/t410: Select ricoh driver
Fix for CB:35086. Build the Ricoh SDcard driver that is defined in devicetree.
Change-Id: Ib0ac3da088d798c35e2c5ea045ea721c89d9e12f Signed-off-by: Patrick Rudolph siro@das-labor.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/37625 Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/t410/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Philipp Deppenwiese: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t410/Kconfig b/src/mainboard/lenovo/t410/Kconfig index 943bf43..f97a093 100644 --- a/src/mainboard/lenovo/t410/Kconfig +++ b/src/mainboard/lenovo/t410/Kconfig @@ -22,6 +22,7 @@ select MAINBOARD_USES_IFD_GBE_REGION select H8_HAS_BAT_TRESHOLDS_IMPL select MAINBOARD_HAS_LIBGFXINIT + select DRIVERS_RICOH_RCE822
config VBOOT select VBOOT_VBNV_CMOS
-
Patrick Rudolph (Code Review) -
Paul Menzel (Code Review)
-
Philipp Deppenwiese (Code Review)