Attention is currently required from: Nick Vaccaro, Paul Menzel.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78009?usp=email )
Change subject: mb/google/brox: Create new Brox baseboard ......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/google/brox/variants/brox/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/78009/comment/73d75331_11c982ba : PS8, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later : # This is an auto-generated file. Do not edit!! : # Generated by: : # util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brox/variants/skolas/memory src/mainboard/google/brox/variants/skolas/memory/mem_parts_used.txt : : SPD_SOURCES = : SPD_SOURCES += spd/lp5/set-1/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B
Please see and use https://chromium-review.googlesource. […]
generated with ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brox/variants/brox/memory src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt
File src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/78009/comment/7809a186_36644f55 : PS8, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later : # This is an auto-generated file. Do not edit!! : # Generated by: : # util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brox/variants/skolas/memory src/mainboard/google/brox/variants/skolas/memory/mem_parts_used.txt : : DRAM Part Name ID to assign
Please see and use https://chromium-review.googlesource. […]
Ok, I see what you are getting at now. It's now generated with ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brox/variants/brox/memory src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt
File src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt:
PS8:
Please see and use https://chromium-review.googlesource. […]
generated with ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brox/variants/brox/memory src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt