Attention is currently required from: Michał Żygowski, Michał Kopeć, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59808 )
Change subject: src/northbridge/amd/pi/00730F01: enable PARALLEL_MP
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/59808/comment/9d2f4ed0_afd36032
PS4, Line 900: /* The flash is now no longer cacheable. Reset to WP for performance. */
: mtrr_use_temp_range(OPTIMAL_CACHE_ROM_BASE, OPTIMAL_CACHE_ROM_SIZE,
: MTRR_TYPE_WRPROT);
Any reason not to do this earlier, e.g. in `pre_mp_init()`? If so, why not do this in the `post_mp_init` hook of `struct mp_ops`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib49e7d3f5956ac7831664d50db5f233b70aa54db
Gerrit-Change-Number: 59808
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 02 Dec 2021 12:20:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment