Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45672 )
Change subject: mb/msi/ms7707/Kconfig: Drop invalid defaults ......................................................................
mb/msi/ms7707/Kconfig: Drop invalid defaults
The PCI ID corresponds to the iGPU, which is disabled in the devicetree. Also, the VBIOS file does not exist at the specified location.
Change-Id: I4f128d3057dc7218f32320c4e23466eb31af4e54 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/msi/ms7707/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/45672/1
diff --git a/src/mainboard/msi/ms7707/Kconfig b/src/mainboard/msi/ms7707/Kconfig index e6095ba..93a43f9 100644 --- a/src/mainboard/msi/ms7707/Kconfig +++ b/src/mainboard/msi/ms7707/Kconfig @@ -33,12 +33,4 @@ hex default 0x200000
-config VGA_BIOS_FILE - string - default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/vgabios.bin" - -config VGA_BIOS_ID - string - default "8086,0102" - endif
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45672 )
Change subject: mb/msi/ms7707/Kconfig: Drop invalid defaults ......................................................................
Patch Set 4: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45672 )
Change subject: mb/msi/ms7707/Kconfig: Drop invalid defaults ......................................................................
mb/msi/ms7707/Kconfig: Drop invalid defaults
The PCI ID corresponds to the iGPU, which is disabled in the devicetree. Also, the VBIOS file does not exist at the specified location.
Change-Id: I4f128d3057dc7218f32320c4e23466eb31af4e54 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45672 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/msi/ms7707/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/msi/ms7707/Kconfig b/src/mainboard/msi/ms7707/Kconfig index e6095ba..93a43f9 100644 --- a/src/mainboard/msi/ms7707/Kconfig +++ b/src/mainboard/msi/ms7707/Kconfig @@ -33,12 +33,4 @@ hex default 0x200000
-config VGA_BIOS_FILE - string - default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/vgabios.bin" - -config VGA_BIOS_ID - string - default "8086,0102" - endif
-
Angel Pons (Code Review) -
Nico Huber (Code Review)