Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40926 )
Change subject: mb/google/reef: Add and use VBT ......................................................................
mb/google/reef: Add and use VBT
Add VBT file, and override use via Kconfig since all Reef variants use the same VBT file.
Test: built/boot google/reef w/FSP display init
Change-Id: I31156ec7371c0443719fdd9ddac6ed4960c83767 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/reef/Kconfig A src/mainboard/google/reef/data.vbt 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/40926/1
diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index 5d782b1..5bdec88 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -12,6 +12,7 @@ select EC_GOOGLE_CHROMEEC_LPC select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select INTEL_GMA_HAVE_VBT select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_I2C_TPM_CR50 @@ -100,4 +101,8 @@ default 0xe00 if CHROMEOS default 0xc00
+# Override the default behavior, since the data.vbt is the same # for all variants +config INTEL_GMA_VBT_FILE + default "src/mainboard/$(MAINBOARDDIR)/data.vbt" + endif # BOARD_GOOGLE_REEF diff --git a/src/mainboard/google/reef/data.vbt b/src/mainboard/google/reef/data.vbt new file mode 100644 index 0000000..d9a55d2 --- /dev/null +++ b/src/mainboard/google/reef/data.vbt Binary files differ
Matt DeVillier has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40926 )
Change subject: mb/google/reef: Add and use VBT ......................................................................
mb/google/reef: Add and use VBT
Add VBT file, and override use via Kconfig since all Reef variants use the same VBT file.
Test: built/boot google/reef w/FSP display init
Change-Id: I31156ec7371c0443719fdd9ddac6ed4960c83767 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/reef/Kconfig A src/mainboard/google/reef/data.vbt 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/40926/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40926 )
Change subject: mb/google/reef: Add and use VBT ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40926/2/src/mainboard/google/reef/K... File src/mainboard/google/reef/Kconfig:
https://review.coreboot.org/c/coreboot/+/40926/2/src/mainboard/google/reef/K... PS2, Line 107: # Oops, spurious '#' ?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40926 )
Change subject: mb/google/reef: Add and use VBT ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40926/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40926/2//COMMIT_MSG@9 PS2, Line 9: Add VBT file, and override use via Kconfig since all Reef variants It’d be great, if you documented where you got this file from.
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40926
to look at the new patch set (#3).
Change subject: mb/google/reef: Add and use VBT ......................................................................
mb/google/reef: Add and use VBT
Add VBT file, and override use via Kconfig since all Reef variants use the same VBT file.
Test: built/boot google/reef w/FSP display init
Change-Id: I31156ec7371c0443719fdd9ddac6ed4960c83767 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/reef/Kconfig A src/mainboard/google/reef/data.vbt 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/40926/3
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40926
to look at the new patch set (#4).
Change subject: mb/google/reef: Add and use VBT ......................................................................
mb/google/reef: Add and use VBT
Add VBT file, and override use via Kconfig since all Reef variants use the same VBT file.
VBT extracted from firmware in ChromeOS recovery image.
Test: built/boot google/reef w/FSP display init
Change-Id: I31156ec7371c0443719fdd9ddac6ed4960c83767 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/reef/Kconfig A src/mainboard/google/reef/data.vbt 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/40926/4
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40926 )
Change subject: mb/google/reef: Add and use VBT ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40926/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40926/2//COMMIT_MSG@9 PS2, Line 9: Add VBT file, and override use via Kconfig since all Reef variants
It’d be great, if you documented where you got this file from.
Done
https://review.coreboot.org/c/coreboot/+/40926/2/src/mainboard/google/reef/K... File src/mainboard/google/reef/Kconfig:
https://review.coreboot.org/c/coreboot/+/40926/2/src/mainboard/google/reef/K... PS2, Line 107: #
Oops, spurious '#' ?
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40926 )
Change subject: mb/google/reef: Add and use VBT ......................................................................
Patch Set 4: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40926 )
Change subject: mb/google/reef: Add and use VBT ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40926 )
Change subject: mb/google/reef: Add and use VBT ......................................................................
mb/google/reef: Add and use VBT
Add VBT file, and override use via Kconfig since all Reef variants use the same VBT file.
VBT extracted from firmware in ChromeOS recovery image.
Test: built/boot google/reef w/FSP display init
Change-Id: I31156ec7371c0443719fdd9ddac6ed4960c83767 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40926 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/reef/Kconfig A src/mainboard/google/reef/data.vbt 2 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index 6b970b2..25d02cd 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -12,6 +12,7 @@ select EC_GOOGLE_CHROMEEC_LPC select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select INTEL_GMA_HAVE_VBT select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_I2C_TPM_CR50 @@ -103,4 +104,8 @@ config FMDFILE default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/default.fmd" if !CHROMEOS
+# Override the default behavior, since the data.vbt is the same for all variants +config INTEL_GMA_VBT_FILE + default "src/mainboard/$(MAINBOARDDIR)/data.vbt" + endif # BOARD_GOOGLE_REEF diff --git a/src/mainboard/google/reef/data.vbt b/src/mainboard/google/reef/data.vbt new file mode 100644 index 0000000..d9a55d2 --- /dev/null +++ b/src/mainboard/google/reef/data.vbt Binary files differ
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)