Attention is currently required from: Nico Huber, Julius Werner.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49960 )
Change subject: console/vtxprintf.c: Correct code style
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I'm not a fan of changing existing code style unless there is […]
I was not aware of the previous discussions about the checkpatch on actual code.
How will this be handled for files with a new patch?
Should the whole file match the rules or just the new code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49960
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb200bf7dd1ef7632aa4e1213bce72d9165560c9
Gerrit-Change-Number: 49960
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 04 Feb 2021 07:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment