Change in ...coreboot[master]: nb/amd/amdfam10/util.c: Use "CONFIG" only when appropriate
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31848
Change subject: nb/amd/amdfam10/util.c: Use "CONFIG" only when appropriate ......................................................................
nb/amd/amdfam10/util.c: Use "CONFIG" only when appropriate
Change-Id: Idcdbbfa883c906db1ebb8d9bc7c9e277e7c0c949 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/util.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/31848/1
diff --git a/src/northbridge/amd/amdfam10/util.c b/src/northbridge/amd/amdfam10/util.c index 41f4deb..9941aec 100644 --- a/src/northbridge/amd/amdfam10/util.c +++ b/src/northbridge/amd/amdfam10/util.c @@ -135,7 +135,7 @@ static void showconfig(int level, u8 which, u32 reg) { /* Don't use r_node() and r_link() here. */ - printk(level, "CONFIG(%02x)%02x-%02x ->(%d,%d),%s %s (%s numbers)\n", + printk(level, "Config(%02x)%02x-%02x ->(%d,%d),%s %s (%s numbers)\n", which, BITS(reg, 16, 0xff), BITS(reg, 24, 0xff), BITS(reg, 4, 0x7), BITS(reg, 8, 0x3), re(reg), we(reg),
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31848 )
Change subject: nb/amd/amdfam10/util.c: Use "CONFIG" only when appropriate ......................................................................
Patch Set 1: Code-Review+1
According to MAINTAINERS I think(?) Tim Pearson is managing these? Not sure why Gerrit didn't auto-CC him.
I'm okay with this change, but I also don't want to change someone else's log output without asking. This is technically a bug in the linter, not the code, but if nobody cares about the exact wording in the log output this would be an easy way to get rid of a spurious warning.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31848 )
Change subject: nb/amd/amdfam10/util.c: Use "CONFIG" only when appropriate ......................................................................
Patch Set 1: Code-Review+2
Looks like there's no real maintainer interest in this, so let's just merge it.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31848 )
Change subject: nb/amd/amdfam10/util.c: Use "CONFIG" only when appropriate ......................................................................
nb/amd/amdfam10/util.c: Use "CONFIG" only when appropriate
Change-Id: Idcdbbfa883c906db1ebb8d9bc7c9e277e7c0c949 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31848 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/northbridge/amd/amdfam10/util.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/northbridge/amd/amdfam10/util.c b/src/northbridge/amd/amdfam10/util.c index 20e5910..39c2bfb 100644 --- a/src/northbridge/amd/amdfam10/util.c +++ b/src/northbridge/amd/amdfam10/util.c @@ -128,7 +128,7 @@ static void showconfig(int level, u8 which, u32 reg) { /* Don't use r_node() and r_link() here. */ - printk(level, "CONFIG(%02x)%02x-%02x ->(%d,%d),%s %s (%s numbers)\n", + printk(level, "Config(%02x)%02x-%02x ->(%d,%d),%s %s (%s numbers)\n", which, BITS(reg, 16, 0xff), BITS(reg, 24, 0xff), BITS(reg, 4, 0x7), BITS(reg, 8, 0x3), re(reg), we(reg),
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)