Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86022?usp=email )
Change subject: tree: Use boolean for docking_supported ......................................................................
tree: Use boolean for docking_supported
Change-Id: I25f09457edf4cfb9bec6939de3e56c2ea7965801 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/86022 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com --- M src/mainboard/asrock/b75pro3-m/devicetree.cb M src/mainboard/compulab/intense_pc/devicetree.cb M src/mainboard/dell/e7240/devicetree.cb M src/mainboard/dell/snb_ivb_latitude/devicetree.cb M src/mainboard/dell/xps_8300/devicetree.cb M src/mainboard/getac/p470/devicetree.cb M src/mainboard/hp/snb_ivb_desktops/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/8560w/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb M src/mainboard/lenovo/l520/devicetree.cb M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t410/devicetree.cb M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t430s/devicetree.cb M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/x201/devicetree.cb M src/mainboard/lenovo/x230/variants/x230/overridetree.cb M src/mainboard/msi/ms7707/devicetree.cb M src/mainboard/roda/rk886ex/devicetree.cb M src/southbridge/intel/bd82x6x/chip.h M src/southbridge/intel/ibexpeak/chip.h 21 files changed, 21 insertions(+), 21 deletions(-)
Approvals: Jérémy Compostella: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/asrock/b75pro3-m/devicetree.cb b/src/mainboard/asrock/b75pro3-m/devicetree.cb index 1cf5015..161c613 100644 --- a/src/mainboard/asrock/b75pro3-m/devicetree.cb +++ b/src/mainboard/asrock/b75pro3-m/devicetree.cb @@ -26,7 +26,7 @@ subsystemid 0x1849 0x0152 end chip southbridge/intel/bd82x6x - register "docking_supported" = "0" + register "docking_supported" = "false" register "gen1_dec" = "0x000c0291" register "gen2_dec" = "0x000c0241" register "gen3_dec" = "0x000c0251" diff --git a/src/mainboard/compulab/intense_pc/devicetree.cb b/src/mainboard/compulab/intense_pc/devicetree.cb index 0c79309..9e75c64 100644 --- a/src/mainboard/compulab/intense_pc/devicetree.cb +++ b/src/mainboard/compulab/intense_pc/devicetree.cb @@ -24,7 +24,7 @@
subsystemid 0x8086 0x7270 inherit chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH - register "docking_supported" = "1" + register "docking_supported" = "true" register "gen1_dec" = "0x0000164d" register "gen2_dec" = "0x000c0681" register "gen3_dec" = "0x000406f1" diff --git a/src/mainboard/dell/e7240/devicetree.cb b/src/mainboard/dell/e7240/devicetree.cb index ee5f1ab..07d7cd1 100644 --- a/src/mainboard/dell/e7240/devicetree.cb +++ b/src/mainboard/dell/e7240/devicetree.cb @@ -31,7 +31,7 @@ device pci 03.0 on end # Mini-HD audio
chip southbridge/intel/lynxpoint # Intel Series 8 Lynx Point PCH - register "docking_supported" = "1" + register "docking_supported" = "true" register "alt_gp_smi_en" = "0x00002000" register "gpe0_en_1" = "0x00000100" register "gpe0_en_2" = "0x00000080" diff --git a/src/mainboard/dell/snb_ivb_latitude/devicetree.cb b/src/mainboard/dell/snb_ivb_latitude/devicetree.cb index f00922b..1f12a5a 100644 --- a/src/mainboard/dell/snb_ivb_latitude/devicetree.cb +++ b/src/mainboard/dell/snb_ivb_latitude/devicetree.cb @@ -18,7 +18,7 @@ end
chip southbridge/intel/bd82x6x # Intel 6/7 Series PCH - register "docking_supported" = "1" + register "docking_supported" = "true"
register "gpi0_routing" = "2" register "pcie_hotplug_map" = "{ 0, 0, 1, 1, 0, 0, 0, 0 }" diff --git a/src/mainboard/dell/xps_8300/devicetree.cb b/src/mainboard/dell/xps_8300/devicetree.cb index 233f946..8bf49cc 100644 --- a/src/mainboard/dell/xps_8300/devicetree.cb +++ b/src/mainboard/dell/xps_8300/devicetree.cb @@ -5,7 +5,7 @@ device domain 0x0 on subsystemid 0x1028 0x04aa inherit chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH - register "docking_supported" = "0" + register "docking_supported" = "false" register "pcie_port_coalesce" = "1"
register "usb_port_config" = "{ diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb index 86bae67..cbd5f0b 100644 --- a/src/mainboard/getac/p470/devicetree.cb +++ b/src/mainboard/getac/p470/devicetree.cb @@ -42,7 +42,7 @@ register "ide_enable_secondary" = "false"
register "c3_latency" = "85" - register "docking_supported" = "1" + register "docking_supported" = "true" register "p_cnt_throttling_supported" = "true"
register "gen1_dec" = "0x001c02e1" diff --git a/src/mainboard/hp/snb_ivb_desktops/devicetree.cb b/src/mainboard/hp/snb_ivb_desktops/devicetree.cb index 113b555..6f3d28e 100644 --- a/src/mainboard/hp/snb_ivb_desktops/devicetree.cb +++ b/src/mainboard/hp/snb_ivb_desktops/devicetree.cb @@ -15,7 +15,7 @@ device ref peg60 off end
chip southbridge/intel/bd82x6x # Intel Series 7 PCH - register "docking_supported" = "0" + register "docking_supported" = "false" register "gen1_dec" = "0x00fc0601" register "gen2_dec" = "0x00fc0801" register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8560w/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8560w/overridetree.cb index 6a1cd14..b47fcbb 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/8560w/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/8560w/overridetree.cb @@ -8,7 +8,7 @@ device ref igd off end
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH - register "docking_supported" = "0" + register "docking_supported" = "false" register "gpi6_routing" = "2" register "pcie_hotplug_map" = "{ 0, 1, 1, 0, 0, 0, 0, 0 }" # HDD(0), ODD(1), eSATA(4) diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb index 771cda0..1ea6bb0 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb @@ -12,7 +12,7 @@ device ref igd off end
chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH - register "docking_supported" = "0" + register "docking_supported" = "false" # mailbox at 0x200/0x201 and PM1 at 0x220 register "gen1_dec" = "0x007c0201" register "gen2_dec" = "0x000c0101" diff --git a/src/mainboard/lenovo/l520/devicetree.cb b/src/mainboard/lenovo/l520/devicetree.cb index e398e78..d592caa 100644 --- a/src/mainboard/lenovo/l520/devicetree.cb +++ b/src/mainboard/lenovo/l520/devicetree.cb @@ -28,7 +28,7 @@ device ref igd on end # Internal graphics VGA controller
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH - register "docking_supported" = "1" + register "docking_supported" = "true" register "gen1_dec" = "0x007c1611" register "gen2_dec" = "0x00040069" register "gen3_dec" = "0x000c0701" diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index eb832be..4e450ea 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -20,7 +20,7 @@ device ref igd on end # Internal graphics VGA controller
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH - register "docking_supported" = "1" + register "docking_supported" = "true" register "gen1_dec" = "0x00000000" register "gen2_dec" = "0x000c0701" register "gen3_dec" = "0x000c0069" diff --git a/src/mainboard/lenovo/t410/devicetree.cb b/src/mainboard/lenovo/t410/devicetree.cb index 8d4ab5f..1ef7075 100644 --- a/src/mainboard/lenovo/t410/devicetree.cb +++ b/src/mainboard/lenovo/t410/devicetree.cb @@ -48,7 +48,7 @@ register "gen3_dec" = "0x1c1681" # EC ? register "gen4_dec" = "0x040069" # ?
- register "docking_supported" = "1" + register "docking_supported" = "true"
register "pcie_hotplug_map" = "{ 0, 0, 0, 1, 0, 0, 0, 0 }"
diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index f0f7975..f86c31a 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -20,7 +20,7 @@ subsystemid 0x17aa 0x21f3 inherit
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH - register "docking_supported" = "1" + register "docking_supported" = "true" register "gen1_dec" = "0x000c15e1" register "gen2_dec" = "0x007c1601" register "gen3_dec" = "0x000c06a1" diff --git a/src/mainboard/lenovo/t430s/devicetree.cb b/src/mainboard/lenovo/t430s/devicetree.cb index 10a388a..ba24ca9 100644 --- a/src/mainboard/lenovo/t430s/devicetree.cb +++ b/src/mainboard/lenovo/t430s/devicetree.cb @@ -47,7 +47,7 @@
# Enable zero-based linear PCIe root port functions register "pcie_port_coalesce" = "true" - register "docking_supported" = "1" + register "docking_supported" = "true"
register "spi_uvscc" = "0x2005" register "spi_lvscc" = "0x2005" diff --git a/src/mainboard/lenovo/t530/devicetree.cb b/src/mainboard/lenovo/t530/devicetree.cb index b8dcfd0..4673aba 100644 --- a/src/mainboard/lenovo/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/devicetree.cb @@ -48,7 +48,7 @@ register "superspeed_capable_ports" = "0xf" register "xhci_overcurrent_mapping" = "0x04000201"
- register "docking_supported" = "1" + register "docking_supported" = "true"
register "spi_uvscc" = "0x2005" register "spi_lvscc" = "0x2005" diff --git a/src/mainboard/lenovo/x201/devicetree.cb b/src/mainboard/lenovo/x201/devicetree.cb index 6c27f53..0be8a3b 100644 --- a/src/mainboard/lenovo/x201/devicetree.cb +++ b/src/mainboard/lenovo/x201/devicetree.cb @@ -48,7 +48,7 @@ register "gen3_dec" = "0x1c1681" register "gen4_dec" = "0x040069"
- register "docking_supported" = "1" + register "docking_supported" = "true"
register "pcie_hotplug_map" = "{ 0, 0, 0, 1, 0, 0, 0, 0 }"
diff --git a/src/mainboard/lenovo/x230/variants/x230/overridetree.cb b/src/mainboard/lenovo/x230/variants/x230/overridetree.cb index e7b06b6..1a226fa 100644 --- a/src/mainboard/lenovo/x230/variants/x230/overridetree.cb +++ b/src/mainboard/lenovo/x230/variants/x230/overridetree.cb @@ -1,7 +1,7 @@ chip northbridge/intel/sandybridge device domain 0 on chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH - register "docking_supported" = "1" + register "docking_supported" = "true" register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }" register "usb_port_config" = "{ {1, 0, 0 }, /* P0 (left, fan side), OC 0 */ diff --git a/src/mainboard/msi/ms7707/devicetree.cb b/src/mainboard/msi/ms7707/devicetree.cb index df1696a..26b3ec8 100644 --- a/src/mainboard/msi/ms7707/devicetree.cb +++ b/src/mainboard/msi/ms7707/devicetree.cb @@ -8,7 +8,7 @@ device ref igd off end # Internal graphics
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH - register "docking_supported" = "0" + register "docking_supported" = "false" register "gen1_dec" = "0x000c0291" register "gen2_dec" = "0x000c0a01" register "pcie_port_coalesce" = "true" diff --git a/src/mainboard/roda/rk886ex/devicetree.cb b/src/mainboard/roda/rk886ex/devicetree.cb index 52c96de..21069dc 100644 --- a/src/mainboard/roda/rk886ex/devicetree.cb +++ b/src/mainboard/roda/rk886ex/devicetree.cb @@ -37,7 +37,7 @@ register "gpe0_en" = "0x20800007"
register "c3_latency" = "0x23" - register "docking_supported" = "1" + register "docking_supported" = "true" register "p_cnt_throttling_supported" = "true"
register "sata_mode" = "SATA_MODE_IDE_LEGACY_COMBINED" diff --git a/src/southbridge/intel/bd82x6x/chip.h b/src/southbridge/intel/bd82x6x/chip.h index 0ec97bd..188595a 100644 --- a/src/southbridge/intel/bd82x6x/chip.h +++ b/src/southbridge/intel/bd82x6x/chip.h @@ -64,7 +64,7 @@ /* Override PCIe ASPM */ uint8_t pcie_aspm[8];
- int docking_supported; + bool docking_supported;
bool pcie_hotplug_map[8];
diff --git a/src/southbridge/intel/ibexpeak/chip.h b/src/southbridge/intel/ibexpeak/chip.h index dc97da3..8b283d9 100644 --- a/src/southbridge/intel/ibexpeak/chip.h +++ b/src/southbridge/intel/ibexpeak/chip.h @@ -64,7 +64,7 @@ /* Override PCIe ASPM */ uint8_t pcie_aspm[8];
- int docking_supported; + bool docking_supported;
bool pcie_hotplug_map[8];
-
Elyes Haouas (Code Review)