Martin Roth has posted comments on this change. ( https://review.coreboot.org/22569 )
Change subject: amd/stoneyridge: Delete early_setup.c ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/22569/1/src/mainboard/google/kahlee/ec.c File src/mainboard/google/kahlee/ec.c:
https://review.coreboot.org/#/c/22569/1/src/mainboard/google/kahlee/ec.c@55 PS1, Line 55: printk(BIOS_DEBUG, "Failed to assign a range\n"); What's the impact of a failure here? Should this maybe be a higher debug level than BIOS_DEBUG?
printk(BIOS_WARNING, "ERROR: Failed to assign a range\n");
die("ERROR: Failed to assign a range\n");