Attention is currently required from: Michał Kopeć, Michał Żygowski, Patrick Rudolph, Paul Menzel, Sergii Dmytruk.
Krystian Hebel has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82555?usp=email )
Change subject: mb/qemu-{i440fx,q35}/rom_media.c: add code for writable flash
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82555/comment/e6969ffc_73d38479?usp... :
PS4, Line 18: 8
The default is BOARD_ROMSIZE_KB_16384. […]
Changed in CB:82639. QEMU bails out immediately, but only for `-drive if=pflash`, `-bios` can use up to 16M images.
File src/mainboard/emulation/qemu-i440fx/rom_media.c:
https://review.coreboot.org/c/coreboot/+/82555/comment/fbfa09dc_18be5128?usp... :
PS4, Line 138: uintptr_t
base is a pointer, no need for cast here
Acknowledged
https://review.coreboot.org/c/coreboot/+/82555/comment/477887e3_29e5d495?usp... :
PS4, Line 158: flash_ops
Should there be a readat() implementation that is always available?
`mdev_readat` is used for all 3 options, it is copied in line 131 from `mem_rdev_rw_ops`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82555?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ab9f22c6165064a769881d4be5eab13a0a2f519
Gerrit-Change-Number: 82555
Gerrit-PatchSet: 5
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Fri, 24 May 2024 12:23:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com