Attention is currently required from: Bora Guvendik, Nico Huber, Selma Bensaid, Tim Wawrzynczak, Angel Pons, Arthur Heymans.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61885 )
Change subject: device: Add device operation to check device driver capabilities
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
These are all good examples when some abstraction is needed in coreboot. However, […]
Your point is valid. And indeed, you're right. I am looking for a cleaner way to generate acpi tables considering different board SKUs at this time. Please also take a look on how it is used in the other review: https://review.coreboot.org/c/coreboot/+/61887/5/src/mainboard/google/brya/v.... Perhaps, this can be done with the current mechanism without being 'hard-code' like approach and something that I miss. If so, please point out!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ed5d27a8e6e441be36b58b54f2a00ec4c1f791f
Gerrit-Change-Number: 61885
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 16 Feb 2022 22:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment