Attention is currently required from: Raul Rangel, Jason Nien, Martin Roth, Tim Van Patten, Karthikeyan Ramasubramanian.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67209 )
Change subject: mb/google/skyrim/var/winterhold: Add gpio override settings
......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/google/skyrim/variants/winterhold/gpio.c:
https://review.coreboot.org/c/coreboot/+/67209/comment/5a6a0ba9_9cf75897
PS4, Line 10: // NC
Remove these extra comments. […]
Done
https://review.coreboot.org/c/coreboot/+/67209/comment/f50d3504_fbab0b3c
PS4, Line 16: SD_AUX_RESET_L
nit: SD_AUX_RST_SOC_L (to match Glacier_Mendocino_FT6_SOC_GPIO_PM&Strap_20220815A)
Done
https://review.coreboot.org/c/coreboot/+/67209/comment/20fe5549_be399440
PS4, Line 22: /* CLK_REQ1_L / EMMC */
How about this?
The REQ1 is for EMMC on winterhold
https://review.coreboot.org/c/coreboot/+/67209/comment/bd7111ed_b15ba639
PS4, Line 25: __weak
You don't want to make this weak
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2086c326cbf46ba6378d18d37dcbbe9fafa6b2bc
Gerrit-Change-Number: 67209
Gerrit-PatchSet: 5
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Fri, 02 Sep 2022 07:41:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment