Attention is currently required from: Paul Menzel, Ronak Kanabar, Subrata Banik.
Appukuttan V K has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82425?usp=email )
Change subject: vc/edk2-stable202302: Add config guards to support FSP 2.4 ......................................................................
Patch Set 16:
(5 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/82425/comment/9eabf329_2d28a825?usp... : PS13, Line 8:
It’d be great if you described the problem in more detail.
Done
https://review.coreboot.org/c/coreboot/+/82425/comment/c042a250_be7a1beb?usp... : PS13, Line 14: have been
are
Done
https://review.coreboot.org/c/coreboot/+/82425/comment/516e56a6_e336382b?usp... : PS13, Line 15: Added
Add
Done
https://review.coreboot.org/c/coreboot/+/82425/comment/d84c8dbd_8e008fb0?usp... : PS13, Line 17: Introduced
Introduce
Done
File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h:
https://review.coreboot.org/c/coreboot/+/82425/comment/cc517001_09f69f3f?usp... : PS12, Line 257: PLATFORM_USES_FSP2_X86_32
as per this CL, FSPM_ARCH2_UPD/FSPS_ARCH2_UPD only enable for PLATFORM_USES_FSP2_X86_64,but that i […]
Moved x86_32 specific structures under PLATFORM_USES_FSP2_X86_32 and FSP2.4 specific ones under PLATFORM_USES_FSP2_4 config