Attention is currently required from: Jason Nien, Tim Van Patten.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67211 )
Change subject: skyrim/overridetree: Enable DPTC and No Battery Mode ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/skyrim/variants/skyrim/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/67211/comment/435ea537_de844919 PS3, Line 261: # Throttle (e.g., Low/No Battery) : register "vrm_current_limit_throttle_mA" = "20000" : register "vrm_maximum_current_limit_throttle_mA" = "20000" : register "vrm_soc_current_limit_throttle_mA" = "10000" I would set the values in this CL since it's the CL that enables the feature. Maybe move the `register "dptc_no_battery_mode_enable" = true` right below the `# Throttle` comment so it's obvious that bit is guarding these fields.