Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Tarun.
Subrata Banik has posted comments on this change by Derek Huang. ( https://review.coreboot.org/c/coreboot/+/86673?usp=email )
Change subject: drivers/intel/usb4: Add mainboard function to get EC port
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/meteorlake/retimer.c:
https://review.coreboot.org/c/coreboot/+/86673/comment/b6bd13b6_69010813?usp... :
PS2, Line 23: } else
: ec_port = 0;
use braces as well because `if` is multiline statement
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86673?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibaad2a95d8624564ae012d23e8a7f19f6701db2c
Gerrit-Change-Number: 86673
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Sat, 01 Mar 2025 11:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No