Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, V Sowmya.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81262?usp=email )
Change subject: mb/google/brya: Create a tivviks variant
......................................................................
Patch Set 1: -Code-Review
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81262/comment/d176e7e3_80a964d3 :
PS1, Line 464: select BOARD_ROMSIZE_KB_32768
: select DRIVERS_GENERIC_GPIO_KEYS
: select DRIVERS_GENESYSLOGIC_GL9750
: select DRIVERS_I2C_SX9324
: select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER
: select DRIVERS_INTEL_MIPI_CAMERA
: select HAVE_WWAN_POWER_SEQUENCE
: select INTEL_GMA_HAVE_VBT
why not something like this
```
config BOARD_GOOGLE_TIVVIKS
select BOARD_GOOGLE_NIVVIKS
select SOC_INTEL_TWINLAKE
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81262?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia833a1dad45e13cd271506ade364b116c5880982
Gerrit-Change-Number: 81262
Gerrit-PatchSet: 1
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 19 Mar 2024 17:57:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment