Attention is currently required from: Dtrain Hsu, Eric Lai, Ian Feng, Kenny Pan, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik.
Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79978?usp=email )
Change subject: mb/google/nissa/var/craaskov: Modify ELAN touchscreen enable delay
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79978/comment/22a81149_75dee1a1 :
PS1, Line 7: Modify touchscreen enable delay to meet spec
nit: Modify ELAN touchscreen enable delay
Done
https://review.coreboot.org/c/coreboot/+/79978/comment/6f7b6555_4d98df6b :
PS1, Line 9: Modify touchscreen enable_delay to 6ms to meet with spec.
please also mention ELAN spec version here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79978?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id57ab04e61d9e95c962f2c564d3a7e2e7ed6b992
Gerrit-Change-Number: 79978
Gerrit-PatchSet: 2
Gerrit-Owner: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Kenny Pan
kennypan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kenny Pan
kennypan@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Mon, 15 Jan 2024 08:44:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment