Attention is currently required from: Liju-Clr Chen, Paul Menzel, Rex-BC Chen.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69088 )
Change subject: soc/mediatek/mt8188: Fix AP hang when enabling cpufreq-hw driver
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69088/comment/6984393a_cf7db035
PS4, Line 9: previous patch
use the link to that patch, for example CB:XXXXX, or a complete review.coreboot.org URL
File src/soc/mediatek/mt8188/devapc.c:
https://review.coreboot.org/c/coreboot/+/69088/comment/1af1bbb4_c5887652
PS4, Line 1556: /* Default APC setting */
should we add a TODO before this?
/* TODO: Setup SCP, SSPM and MCUPM permissions in APC . */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69088
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67b08c38a31a7eae1bc59543a5148a78b61456d6
Gerrit-Change-Number: 69088
Gerrit-PatchSet: 4
Gerrit-Owner: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 07:45:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment