Angel Pons has uploaded this change for review. ( https://review.coreboot.org/27212
Change subject: mb/*/*: Drop VGA_BIOS_FILE and VGA_BIOS_ID on some cases ......................................................................
mb/*/*: Drop VGA_BIOS_FILE and VGA_BIOS_ID on some cases
If a certain mainboard does not have a specific CPU paired with it, VGA_BIOS_FILE and VGA_BIOS_ID should not be set to a CPU-specific default. The only exceptions are boards which are always paired with the same CPU model.
This patch set only modifies SNB/IVB boards as of now, though the concept can be applied to other generations.
Change-Id: I5b70974b47d04267770c8e91b7663450f0e2dbbb Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/asus/maximus_iv_gene-z/Kconfig M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/gigabyte/ga-b75m-d3h/Kconfig M src/mainboard/gigabyte/ga-b75m-d3v/Kconfig M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/revolve_810_g1/Kconfig M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/mainboard/sapphire/pureplatinumh61/Kconfig 26 files changed, 0 insertions(+), 187 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/27212/1
diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index bdfe667..c87a7c0 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -31,14 +31,6 @@ string default "MacBookAir4,2"
-config VGA_BIOS_FILE - string - default "pci8086,0116.rom" - -config VGA_BIOS_ID - string - default "8086,0116" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x7270 diff --git a/src/mainboard/asus/maximus_iv_gene-z/Kconfig b/src/mainboard/asus/maximus_iv_gene-z/Kconfig index eacf92e..73616d4 100644 --- a/src/mainboard/asus/maximus_iv_gene-z/Kconfig +++ b/src/mainboard/asus/maximus_iv_gene-z/Kconfig @@ -44,10 +44,6 @@ string default "Maximus IV GENE-Z"
-config VGA_BIOS_ID - string - default "8086,0112" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x844d diff --git a/src/mainboard/compulab/intense_pc/Kconfig b/src/mainboard/compulab/intense_pc/Kconfig index 557b8ff..8ccb7a7 100644 --- a/src/mainboard/compulab/intense_pc/Kconfig +++ b/src/mainboard/compulab/intense_pc/Kconfig @@ -36,10 +36,6 @@ string default "Intense-PC"
-config VGA_BIOS_ID - string - default "8086,0166" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x7270 diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig index 580a9ad..6c3916e 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig @@ -39,14 +39,6 @@ int default 8
-config VGA_BIOS_ID - string - default "8086,0162" - -config VGA_BIOS_FILE - string - default "pci8086,0162.rom" - config HAVE_IFD_BIN bool default n diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig index b8694f5..f6b4072 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig @@ -38,14 +38,6 @@ int default 8
-config VGA_BIOS_ID - string - default "8086,0102" - -config VGA_BIOS_FILE - string - default "pci8086,0102.rom" - config HAVE_IFD_BIN bool default n diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig index f53bc06..8be54d3 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig @@ -48,14 +48,6 @@ string default "GA-H61M-S2PV"
-config VGA_BIOS_FILE - string - default "pci8086,0102.rom" - -config VGA_BIOS_ID - string - default "8086,0102" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x5001 diff --git a/src/mainboard/hp/2570p/Kconfig b/src/mainboard/hp/2570p/Kconfig index dc9588b..4dc4b6e 100644 --- a/src/mainboard/hp/2570p/Kconfig +++ b/src/mainboard/hp/2570p/Kconfig @@ -50,14 +50,6 @@ string default "EliteBook 2570p"
-config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - -config VGA_BIOS_ID - string - default "8086,0166" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x17df diff --git a/src/mainboard/hp/2760p/Kconfig b/src/mainboard/hp/2760p/Kconfig index 7adf209..0ffc798 100644 --- a/src/mainboard/hp/2760p/Kconfig +++ b/src/mainboard/hp/2760p/Kconfig @@ -50,14 +50,6 @@ string default "EliteBook 2760p"
-config VGA_BIOS_FILE - string - default "pci8086,0116.rom" - -config VGA_BIOS_ID - string - default "8086,0116" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x162a diff --git a/src/mainboard/hp/8460p/Kconfig b/src/mainboard/hp/8460p/Kconfig index 1486659..be08678 100644 --- a/src/mainboard/hp/8460p/Kconfig +++ b/src/mainboard/hp/8460p/Kconfig @@ -53,14 +53,6 @@ string default "EliteBook 8460p"
-config VGA_BIOS_FILE - string - default "pci8086,0116.rom" - -config VGA_BIOS_ID - string - default "8086,0116" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x161c diff --git a/src/mainboard/hp/8470p/Kconfig b/src/mainboard/hp/8470p/Kconfig index 2157867..eed0cbe 100644 --- a/src/mainboard/hp/8470p/Kconfig +++ b/src/mainboard/hp/8470p/Kconfig @@ -51,14 +51,6 @@ string default "EliteBook 8470p"
-config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - -config VGA_BIOS_ID - string - default "8086,0166" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x179b diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig index 4e7062e..950b42c 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig @@ -34,14 +34,6 @@ string default "HP Compaq 8200 Elite SFF PC"
-config VGA_BIOS_FILE - string - default "pci8086,0102.rom" - -config VGA_BIOS_ID - string - default "8086,0102" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x1495 diff --git a/src/mainboard/hp/folio_9470m/Kconfig b/src/mainboard/hp/folio_9470m/Kconfig index 188f8d8..510c273 100644 --- a/src/mainboard/hp/folio_9470m/Kconfig +++ b/src/mainboard/hp/folio_9470m/Kconfig @@ -37,14 +37,6 @@ string default "EliteBook Folio 9470m"
-config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - -config VGA_BIOS_ID - string - default "8086,0166" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x18df diff --git a/src/mainboard/hp/revolve_810_g1/Kconfig b/src/mainboard/hp/revolve_810_g1/Kconfig index 7816da5..896eb4c 100644 --- a/src/mainboard/hp/revolve_810_g1/Kconfig +++ b/src/mainboard/hp/revolve_810_g1/Kconfig @@ -39,14 +39,6 @@ string default "EliteBook Revolve 810 G1"
-config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - -config VGA_BIOS_ID - string - default "8086,0166" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x18f8 diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig index 17c2803..fad8e2f 100644 --- a/src/mainboard/kontron/ktqm77/Kconfig +++ b/src/mainboard/kontron/ktqm77/Kconfig @@ -28,10 +28,6 @@ int default 8
-config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x0000 # TODO diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig index 20ed67c..788c296 100644 --- a/src/mainboard/lenovo/l520/Kconfig +++ b/src/mainboard/lenovo/l520/Kconfig @@ -34,14 +34,6 @@ string default "ThinkPad L520"
-config VGA_BIOS_FILE - string - default "pci8086,0126.rom" - -config VGA_BIOS_ID - string - default "8086,0126" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x21dd diff --git a/src/mainboard/lenovo/s230u/Kconfig b/src/mainboard/lenovo/s230u/Kconfig index 2c579b0..3f0b155 100644 --- a/src/mainboard/lenovo/s230u/Kconfig +++ b/src/mainboard/lenovo/s230u/Kconfig @@ -52,14 +52,6 @@ int default 60
-config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - -config VGA_BIOS_ID - string - default "8086,0166" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index 40fd213..c68f6f7 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -57,14 +57,6 @@ int default 10
-config VGA_BIOS_FILE - string - default "pci8086,0126.rom" - -config VGA_BIOS_ID - string - default "8086,0126" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig index ae50975..22a6e70 100644 --- a/src/mainboard/lenovo/t420s/Kconfig +++ b/src/mainboard/lenovo/t420s/Kconfig @@ -53,14 +53,6 @@ int default 10
-config VGA_BIOS_FILE - string - default "pci8086,0126.rom" - -config VGA_BIOS_ID - string - default "8086,0126" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig index a938dcc..2ecaf15 100644 --- a/src/mainboard/lenovo/t430s/Kconfig +++ b/src/mainboard/lenovo/t430s/Kconfig @@ -55,10 +55,6 @@ int default 10
-config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index 824f299..6f6dd23 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -64,14 +64,6 @@ int default 10
-config VGA_BIOS_ID - string - default "8086,0126" - -config VGA_BIOS_FILE - string - default "pci8086,0126.rom" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 0bbf941..ba6c269 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -67,11 +67,6 @@ int default 10
-config VGA_BIOS_FILE - string - default "pci8086,0106.rom" if BOARD_LENOVO_T530 - default "pci8086,0166.rom" if BOARD_LENOVO_W530 - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig index abd3dc3..a71ee44 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig +++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig @@ -54,14 +54,6 @@ int default 10
-config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - -config VGA_BIOS_ID - string - default "8086,0166" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 54d3648..941fadd 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -54,16 +54,6 @@ int default 10
-config VGA_BIOS_FILE - string - default "pci8086,0116.rom" if BOARD_LENOVO_X220I - default "pci8086,0126.rom" - -config VGA_BIOS_ID - string - default "8086,0116" if BOARD_LENOVO_X220I - default "8086,0126" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 29c0e7b..bb760a8 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -55,14 +55,6 @@ int default 10
-config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - -config VGA_BIOS_ID - string - default "8086,0166" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index 8742e5e..003e0ad 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -35,10 +35,6 @@ int default 8
-config VGA_BIOS_FILE - string - default "pci8086,0106.rom" - config MAINBOARD_POWER_ON_AFTER_POWER_FAIL bool default n diff --git a/src/mainboard/sapphire/pureplatinumh61/Kconfig b/src/mainboard/sapphire/pureplatinumh61/Kconfig index 42cda6e..52b9c2a 100644 --- a/src/mainboard/sapphire/pureplatinumh61/Kconfig +++ b/src/mainboard/sapphire/pureplatinumh61/Kconfig @@ -29,14 +29,6 @@ string default "Pure Platinum H61"
-config VGA_BIOS_FILE - string - default "pci8086,0162.rom" - -config VGA_BIOS_ID - string - default "8086,0162" - config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID hex default 0x1007
-
Angel Pons (Code Review)