Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77538?usp=email )
Change subject: mb/google/nissa/var/uldren: Remove fw_config probe for TS and TP ......................................................................
mb/google/nissa/var/uldren: Remove fw_config probe for TS and TP
When service center repair touchscreen or touchpad will change compatible device not specific one, the fw_config probe mechanism is not convenient for service center. Removing touchscreen and touchpad fw_config probe for the purpose.
BUG=b:297840605 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot chromeos-bootimage
Change-Id: I66f12ae478f74c019c53ee5e77f7e0f9c324e758 Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/77538 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Derek Huang derekhuang@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/variants/uldren/overridetree.cb 1 file changed, 8 insertions(+), 32 deletions(-)
Approvals: Derek Huang: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/brya/variants/uldren/overridetree.cb b/src/mainboard/google/brya/variants/uldren/overridetree.cb index 65c8151..829f877 100644 --- a/src/mainboard/google/brya/variants/uldren/overridetree.cb +++ b/src/mainboard/google/brya/variants/uldren/overridetree.cb @@ -222,10 +222,7 @@ register "generic.enable_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x20" - device i2c 2c on - probe TOUCHSCREEN TOUCHSCREEN_UNKNOWN - probe TOUCHSCREEN TOUCHSCREEN_WDT8752A - end + device i2c 2c on end end chip drivers/i2c/generic register "hid" = ""ELAN0001"" @@ -241,10 +238,7 @@ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" register "enable_delay_ms" = "1" register "has_power_resource" = "1" - device i2c 10 on - probe TOUCHSCREEN TOUCHSCREEN_UNKNOWN - probe TOUCHSCREEN TOUCHSCREEN_EKTH5012 - end + device i2c 10 on end end chip drivers/i2c/hid register "generic.hid" = ""ELAN900C"" @@ -260,10 +254,7 @@ register "generic.enable_delay_ms" = "6" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" - device i2c 16 on - probe TOUCHSCREEN TOUCHSCREEN_UNKNOWN - probe TOUCHSCREEN TOUCHSCREEN_EKTH7D18 - end + device i2c 16 on end end chip drivers/i2c/hid register "generic.hid" = ""GXTP7996"" @@ -278,10 +269,7 @@ register "generic.enable_delay_ms" = "10" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" - device i2c 5d on - probe TOUCHSCREEN TOUCHSCREEN_UNKNOWN - probe TOUCHSCREEN TOUCHSCREEN_GT7996F - end + device i2c 5d on end end chip drivers/i2c/hid register "generic.hid" = ""GTCH7502"" @@ -296,10 +284,7 @@ register "generic.enable_delay_ms" = "30" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" - device i2c 40 on - probe TOUCHSCREEN TOUCHSCREEN_UNKNOWN - probe TOUCHSCREEN TOUCHSCREEN_GTCH7502 - end + device i2c 40 on end end chip drivers/i2c/hid register "generic.hid" = ""WDHT2601"" @@ -314,10 +299,7 @@ register "generic.enable_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x20" - device i2c 3c on - probe TOUCHSCREEN TOUCHSCREEN_UNKNOWN - probe TOUCHSCREEN TOUCHSCREEN_WDT8790A - end + device i2c 3c on end end end device ref i2c3 on @@ -345,10 +327,7 @@ register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F14_IRQ)" register "wake" = "GPE0_DW2_14" register "detect" = "1" - device i2c 15 on - probe TOUCHPAD TOUCHPAD_UNKNOWN - probe TOUCHPAD TOUCHPAD_EKT3744 - end + device i2c 15 on end end chip drivers/i2c/hid register "generic.hid" = ""GXTP7863"" @@ -357,10 +336,7 @@ register "generic.wake" = "GPE0_DW2_14" register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20" - device i2c 2c on - probe TOUCHPAD TOUCHPAD_UNKNOWN - probe TOUCHPAD TOUCHPAD_GT7863 - end + device i2c 2c on end end end device ref pcie_rp7 off end