Attention is currently required from: Felix Singer, Xue Yao, Paul Menzel, Kilian Neuner, Angel Pons, Charles Moyes, Alexander Couzens.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 22:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/28950/comment/60345aca_7e50b5dc
PS22, Line 14: uses the same method of enabling the custom eDP panel.
If there was a single way a mod could do it or if this change
would document what mod in what configuration was tested, it
would have been merged years ago, AFAICT.
https://review.coreboot.org/c/coreboot/+/28950/comment/e1ea45b2_f107ec21
PS22, Line 18: brightness controls to work out of the box.
This seems misleading. Yes, it "allows" things to work OOB. But it
doesn't always work OOB. The nitrocaster mod in its default confi-
guration, for instance, is designed to work without firmware modi-
fications and doesn't work well if the firmware is adapted, AIUI.
https://review.coreboot.org/c/coreboot/+/28950/comment/2bbe726e_4a0ebd7c
PS22, Line 24: - Set the DP-3 as internally connected.
This part is missing in the libgfxinit configuration.
File src/mainboard/lenovo/x230/Kconfig:
https://review.coreboot.org/c/coreboot/+/28950/comment/adca0244_3401b880
PS19, Line 26: select GFX_GMA_PANEL_1_ON_EDP if BOARD_LENOVO_X230_EDP
Done
`_EDP` here means the dedicated eDP port. I assume this needs a `DP3`
default for `config GFX_GMA_PANEL_1_PORT`.
File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/28950/comment/fe1c3f04_a84348d5
PS22, Line 11: bool "ThinkPad X230 eDP Mod (2K/FHD)"
Please add a help text about tested mods and their configuration.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 22
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kilian Neuner
cb@9-r.net
Gerrit-Reviewer: Martin L Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aleksei Kharlamov
derlafff@ya.ru
Gerrit-CC: Charles Moyes
thechuckster@gmail.com
Gerrit-CC: Christian Herzog
Gerrit-CC: Holger Levsen
holger@layer-acht.org
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Pavel Kovalenko
su@nitrocaster.me
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Stanislaw Kaminski
stanislaw.kaminski@gmail.com
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao
xueyao@xyte.ch
Gerrit-CC: clayton craft
Gerrit-CC: nullmark
nullmark@googlemail.com
Gerrit-CC: slact
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Xue Yao
xueyao@xyte.ch
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kilian Neuner
cb@9-r.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Charles Moyes
thechuckster@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Sat, 30 Apr 2022 12:43:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment