Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph, Elyes Haouas.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61845 )
Change subject: treewide/azalia: Fix 16-bit read and use common functions
......................................................................
Patch Set 9: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61845/comment/6c32b091_d3aab011
PS9, Line 9: Correct the codec mask and read only 16 bits.
: Use common codec_detect() and azalia_audio_init().
Please either format as a list, or do not wrap the line, just because the sentence ends.
https://review.coreboot.org/c/coreboot/+/61845/comment/08296994_787e81a8
PS9, Line 11:
Tested how?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61845
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I530aa21d5a26ade0bc071351ac609c84bd8eb2cb
Gerrit-Change-Number: 61845
Gerrit-PatchSet: 9
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 30 Apr 2022 11:32:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment