Attention is currently required from: Felix Singer, Xue Yao, Paul Menzel, Kilian Neuner, Angel Pons, Charles Moyes, Alexander Couzens.

View Change

5 comments:

• Commit Message:

  • Patch Set #22, Line 14: uses the same method of enabling the custom eDP panel.

    If there was a single way a mod could do it or if this change
    would document what mod in what configuration was tested, it
    would have been merged years ago, AFAICT.

  • Patch Set #22, Line 18: brightness controls to work out of the box.

    This seems misleading. Yes, it "allows" things to work OOB. But it
    doesn't always work OOB. The nitrocaster mod in its default confi-
    guration, for instance, is designed to work without firmware modi-
    fications and doesn't work well if the firmware is adapted, AIUI.

  • Patch Set #22, Line 24: - Set the DP-3 as internally connected.

    This part is missing in the libgfxinit configuration.

• File src/mainboard/lenovo/x230/Kconfig:

  • Patch Set #19, Line 26: select GFX_GMA_PANEL_1_ON_EDP if BOARD_LENOVO_X230_EDP

    Done

    `_EDP` here means the dedicated eDP port. I assume this needs a `DP3`
    default for `config GFX_GMA_PANEL_1_PORT`.

• File src/mainboard/lenovo/x230/Kconfig.name:

  • Patch Set #22, Line 11: bool "ThinkPad X230 eDP Mod (2K/FHD)"

    Please add a help text about tested mods and their configuration.

To view, visit change 28950. To unsubscribe, or for help writing mail filters, visit settings.