Change in ...coreboot[master]: src/vendorcode: Use 'include <stdlib.h>' when appropriate
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33682
Change subject: src/vendorcode: Use 'include <stdlib.h>' when appropriate ......................................................................
src/vendorcode: Use 'include <stdlib.h>' when appropriate
Change-Id: I70029700bfb297ac06561056da730731a2ca1e8b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c M src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c M src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c M src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c 4 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/33682/1
diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c index 8e348d0..8616fb6 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c @@ -12,6 +12,7 @@
#include <bdk.h> #include <libbdk-hal/bdk-config.h> +#include <stdlib.h> #include <string.h> #include <assert.h> #include <lame_string.h> diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c index f7d631f..c6017b2 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c @@ -37,7 +37,9 @@ * ARISING OUT OF USE OR PERFORMANCE OF THE SOFTWARE LIES WITH YOU. ***********************license end**************************************/ #include <bdk.h> +#include <stdlib.h> #include <string.h> + #include "libbdk-arch/bdk-csrs-gser.h" #include "libbdk-arch/bdk-csrs-gsern.h" #include "libbdk-hal/if/bdk-if.h" diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c index 0df70eb..ed003dc 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c @@ -36,8 +36,11 @@ * QUIET POSSESSION OR CORRESPONDENCE TO DESCRIPTION. THE ENTIRE RISK * ARISING OUT OF USE OR PERFORMANCE OF THE SOFTWARE LIES WITH YOU. ***********************license end**************************************/ + #include <bdk.h> #include <string.h> +#include <stdlib.h> + #include "libbdk-arch/bdk-csrs-ap.h" #include "libbdk-arch/bdk-csrs-pccpf.h" #include "libbdk-hal/bdk-ecam.h" diff --git a/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c b/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c index 385acee..e3fc993 100644 --- a/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c +++ b/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c @@ -40,6 +40,7 @@ #include "dram-internal.h"
#include <string.h> +#include <stdlib.h> #include <lame_string.h> /* for strtoul */ #include <libbdk-hal/bdk-atomic.h> #include <libbdk-hal/bdk-clock.h>
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33682 )
Change subject: src/vendorcode: Use 'include <stdlib.h>' when appropriate ......................................................................
Abandoned
see #32023
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33682 )
Change subject: src/vendorcode: Use 'include <stdlib.h>' when appropriate ......................................................................
Restored
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33682
to look at the new patch set (#5).
Change subject: vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c: Add missing <stdlib.h> ......................................................................
vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c: Add missing <stdlib.h>
Change-Id: I70029700bfb297ac06561056da730731a2ca1e8b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/33682/5
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33682 )
Change subject: vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c: Add missing <stdlib.h> ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33682/10/src/vendorcode/cavium/bdk/... File src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c:
https://review.coreboot.org/c/coreboot/+/33682/10/src/vendorcode/cavium/bdk/... PS10, Line 359: malloc needs <stdlib>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33682 )
Change subject: vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c: Add missing <stdlib.h> ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33682/10/src/vendorcode/cavium/bdk/... File src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c:
https://review.coreboot.org/c/coreboot/+/33682/10/src/vendorcode/cavium/bdk/... PS10, Line 359: malloc
needs <stdlib>
Done
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33682 )
Change subject: vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c: Add missing <stdlib.h> ......................................................................
Patch Set 10: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33682 )
Change subject: vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c: Add missing <stdlib.h> ......................................................................
vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c: Add missing <stdlib.h>
Change-Id: I70029700bfb297ac06561056da730731a2ca1e8b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33682 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c index b9552d4..9fecfcc 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c @@ -37,6 +37,7 @@ * ARISING OUT OF USE OR PERFORMANCE OF THE SOFTWARE LIES WITH YOU. ***********************license end**************************************/ #include <bdk.h> +#include <stdlib.h> #include <string.h> #include "libbdk-arch/bdk-csrs-gser.h" #include "libbdk-arch/bdk-csrs-gsern.h"
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)