Change in ...coreboot[master]: soc/intel/skylake: select FSP_M_XIP if PLATFORM_USES_FSP2_0
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31110
Change subject: soc/intel/skylake: select FSP_M_XIP if PLATFORM_USES_FSP2_0 ......................................................................
soc/intel/skylake: select FSP_M_XIP if PLATFORM_USES_FSP2_0
Select FSP_M_XIP if PLATFORM_USES_FSP2_0, since all SkyKabylake boards require FSP-M XIP when FSP 2.0 is used, and since not having it selected results in a non-booting image.
Also, put select FSP_T_XIP if FSP_CAR in proper alphabetical order.
Change-Id: I6d3986eda18297b12490cefb236f5de5faca6550 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/skylake/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/31110/1
diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index 442b09a..383b397 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -28,6 +28,8 @@ select COMMON_FADT select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select C_ENVIRONMENT_BOOTBLOCK + select FSP_M_XIP if PLATFORM_USES_FSP2_0 + select FSP_T_XIP if FSP_CAR select GENERIC_GPIO_LIB select HAVE_FSP_GOP select INTEL_DESCRIPTOR_MODE_CAPABLE @@ -74,7 +76,6 @@ select TSC_MONOTONIC_TIMER select TSC_SYNC_MFENCE select UDELAY_TSC - select FSP_T_XIP if FSP_CAR
config CPU_INTEL_NUM_FIT_ENTRIES int
Hello Aaron Durbin, Patrick Rudolph, Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31110
to look at the new patch set (#2).
Change subject: soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0 ......................................................................
soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0
Select FSP_M_XIP if MAINBOARD_USES_FSP2_0, since all SkyKabylake boards require FSP-M XIP when FSP 2.0 is used, and since not having it selected results in a non-booting image.
Also, put select FSP_T_XIP if FSP_CAR in proper alphabetical order.
Change-Id: I6d3986eda18297b12490cefb236f5de5faca6550 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/skylake/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/31110/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31110 )
Change subject: soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0 ......................................................................
Patch Set 3:
Thanks! Not in the scope of this change but generally, we might want to remove the prompt for FSP_M_XIP (afaics, there is no platform hook-up that supports both).
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31110 )
Change subject: soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0 ......................................................................
Patch Set 3: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31110 )
Change subject: soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0 ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31110 )
Change subject: soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0 ......................................................................
soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0
Select FSP_M_XIP if MAINBOARD_USES_FSP2_0, since all SkyKabylake boards require FSP-M XIP when FSP 2.0 is used, and since not having it selected results in a non-booting image.
Also, put select FSP_T_XIP if FSP_CAR in proper alphabetical order.
Change-Id: I6d3986eda18297b12490cefb236f5de5faca6550 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/31110 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index ec982d1..506a041 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -28,6 +28,8 @@ select COMMON_FADT select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select C_ENVIRONMENT_BOOTBLOCK + select FSP_M_XIP if MAINBOARD_USES_FSP2_0 + select FSP_T_XIP if FSP_CAR select GENERIC_GPIO_LIB select HAVE_FSP_GOP select INTEL_DESCRIPTOR_MODE_CAPABLE @@ -73,7 +75,6 @@ select TSC_MONOTONIC_TIMER select TSC_SYNC_MFENCE select UDELAY_TSC - select FSP_T_XIP if FSP_CAR
config CPU_INTEL_NUM_FIT_ENTRIES int
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31110 )
Change subject: soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31110/4/src/soc/intel/skylake/Kconfig File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/#/c/31110/4/src/soc/intel/skylake/Kconfig@31 PS4, Line 31: FSP_M_XIP This is true regardless of the FSP version. Sorry if I missed it but did we drop fsp 1.1. support? If so, then it makes sense.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31110 )
Change subject: soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31110/4/src/soc/intel/skylake/Kconfig File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/#/c/31110/4/src/soc/intel/skylake/Kconfig@31 PS4, Line 31: FSP_M_XIP
This is true regardless of the FSP version. Sorry if I missed it but did we drop fsp 1.1. […]
We didn't drop FSP1.1. But it doesn't know the `FSP_M_XIP` Kconfig symbol, hence the guard.
-
Aaron Durbin (Code Review) -
Arthur Heymans (Code Review)
-
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)