[L] Change in coreboot[main]: mainboard: Drop redundant PciRpEnable from devicetrees

[Nico Huber (Code Review)]

Attention is currently required from: Angel Pons, Christian Walter, Erik van den Bogaert, Felix Singer, Frans Hendriks, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nicholas Sudsgaard, Nick Vaccaro, Patrick Rudolph, Piotr Król, Sean Rhodes, Subrata Banik, Tim Crawford, Werner Zeh.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79935?usp=email )

Change subject: mainboard: Drop redundant PciRpEnable from devicetrees
......................................................................

Patch Set 5:

(3 comments)

Patchset:

PS4:
> The patch still needs to be splitted up into the patches for each platform.

There's already a comment open for that.
> Please provide a single command for each platform in order to make that reproducible. Could be done with find and sed.

It's not this easy because there are comments to be altered/moved, override
tree entries to be added etc.
> Also, I would like to make sure that the devicetree configuration matches the configuration of the options. The devicetree reference names should help with that, but the conversion is still WIP for Skylake and Cannonlake.

That's what is to be reviewed in general.

PS4:
> It still complains about volteer/variants/voema, but that looks more […]

Turns out there are special rules when a device contains fw-config `probe'
statements. I've fixed that but am unsure if the override device is necessary
at all.

File src/mainboard/google/volteer/variants/voema/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/79935/comment/bb514556_9c22d97e :
PS5, Line 106: 			# the same device if it has the same probes:
Nick, could you check if overriding this device to `off` would be necessary?
With this patch train, FSP would be configured properly if the device is
assumed off, which might already be the case on Voema due to the probes.