Attention is currently required from: Christopher Meis, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55513 )
Change subject: intel/fit - Prepare for BootGuard support
......................................................................
Patch Set 1:
(1 comment)
File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/55513/comment/86c37572_ab74532c
PS1, Line 16: intel_fit-position := 0xffff0000 # Set position for BootGuard
Where does this requirement come from? reading #558294 I don't see the need for that.
I'm looking at 557867. The requirements are:
- FIT, KM, BPM needs to be in the top 4M
- ACM in top 2M
- All IBBs need to be in the top 4M
Maybe we can get rid of this and just use a small RO region with VBOOT? The tooling has to warn about ill configurations though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If78cc3ea77309abd96a9365f718d99f264381928
Gerrit-Change-Number: 55513
Gerrit-PatchSet: 1
Gerrit-Owner: Christopher Meis
christopher.meis@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christopher Meis
christopher.meis@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Tue, 15 Jun 2021 13:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment