Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46361 )
Change subject: nb/intel/haswell: Drop unnecessary register read ......................................................................
nb/intel/haswell: Drop unnecessary register read
Reading MAD_CHNL has no effect, so there's no need to read it here.
Change-Id: I8d2aa4787de7f54f49d161f61c9c0abaa811cb83 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/raminit.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/46361/1
diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c index 9c6c00f..aaeaadf 100644 --- a/src/northbridge/intel/haswell/raminit.c +++ b/src/northbridge/intel/haswell/raminit.c @@ -227,8 +227,6 @@
memset(mem_info, 0, sizeof(struct memory_info));
- /* FIXME: Do we need to read MCHBAR32(MAD_CHNL) ? (Answer: Nope) */ - MCHBAR32(MAD_CHNL); addr_decode_ch[0] = MCHBAR32(MAD_DIMM_CH0); addr_decode_ch[1] = MCHBAR32(MAD_DIMM_CH1);
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46361 )
Change subject: nb/intel/haswell: Drop unnecessary register read ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46361 )
Change subject: nb/intel/haswell: Drop unnecessary register read ......................................................................
nb/intel/haswell: Drop unnecessary register read
Reading MAD_CHNL has no effect, so there's no need to read it here.
Change-Id: I8d2aa4787de7f54f49d161f61c9c0abaa811cb83 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46361 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/northbridge/intel/haswell/raminit.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c index 9c6c00f..aaeaadf 100644 --- a/src/northbridge/intel/haswell/raminit.c +++ b/src/northbridge/intel/haswell/raminit.c @@ -227,8 +227,6 @@
memset(mem_info, 0, sizeof(struct memory_info));
- /* FIXME: Do we need to read MCHBAR32(MAD_CHNL) ? (Answer: Nope) */ - MCHBAR32(MAD_CHNL); addr_decode_ch[0] = MCHBAR32(MAD_DIMM_CH0); addr_decode_ch[1] = MCHBAR32(MAD_DIMM_CH1);
-
Angel Pons (Code Review) -
Nico Huber (Code Review)