Change in coreboot[master]: arch/x86: Drop weak attribute on stage_cache

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34741 )

Change subject: arch/x86: Drop weak attribute on stage_cache
......................................................................

arch/x86: Drop weak attribute on stage_cache

There are no more cases that need to override this.

Change-Id: Iafa94af19eae00cc5be5d4ff7454066558e3c74f
Signed-off-by: Kyösti Mälkki 
---
M src/cpu/x86/smm/stage_cache.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34741/1

diff --git a/src/cpu/x86/smm/stage_cache.c b/src/cpu/x86/smm/stage_cache.c
index 0a816ba..1c0309c 100644
--- a/src/cpu/x86/smm/stage_cache.c
+++ b/src/cpu/x86/smm/stage_cache.c
@@ -23,7 +23,7 @@
    return -1;
 }

-void __weak stage_cache_external_region(void **base, size_t *size)
+void stage_cache_external_region(void **base, size_t *size)
 {
    if (smm_subregion(SMM_SUBREGION_CACHE, (uintptr_t *)base, size)) {
    	printk(BIOS_ERR, "ERROR: No cache SMM subregion.\n");

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34741 )

Change subject: arch/x86: Drop weak attribute on stage_cache
......................................................................

Patch Set 8: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34741 )

Change subject: arch/x86: Drop weak attribute on stage_cache
......................................................................

arch/x86: Drop weak attribute on stage_cache

There are no more cases that need to override this.

Change-Id: Iafa94af19eae00cc5be5d4ff7454066558e3c74f
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34741
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/cpu/x86/smm/tseg_region.c
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/cpu/x86/smm/tseg_region.c b/src/cpu/x86/smm/tseg_region.c
index 07789f4..75b9988 100644
--- a/src/cpu/x86/smm/tseg_region.c
+++ b/src/cpu/x86/smm/tseg_region.c
@@ -20,12 +20,6 @@
 #include <stage_cache.h>
 #include <types.h>

-void __weak smm_region(uintptr_t *start, size_t *size)
-{
-	*start = 0;
-	*size = 0;
-}
-
 /*
  *        Subregions within SMM
  *     +-------------------------+
@@ -76,7 +70,7 @@
    return 0;
 }

-void __weak stage_cache_external_region(void **base, size_t *size)
+void stage_cache_external_region(void **base, size_t *size)
 {
    if (smm_subregion(SMM_SUBREGION_CACHE, (uintptr_t *)base, size)) {
    	printk(BIOS_ERR, "ERROR: No cache SMM subregion.\n");