Attention is currently required from: Reka Norman, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Subrata Banik, Angel Pons, Krishna P Bhat D, Patrick Rudolph, Kangheui Won.
Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59752 )
Change subject: soc/intel/alderlake: Add support for ADL-N PCH
......................................................................
Patch Set 4:
(5 comments)
Commit Message:
PS2:
I'd squash CB:59751 into this change. […]
Ack
https://review.coreboot.org/c/coreboot/+/59752/comment/67916f75_e7ada22d
PS2, Line 7: Configure 9 I/O for ADL-N
don't able to follow what is `9` here. […]
Ack
https://review.coreboot.org/c/coreboot/+/59752/comment/052aecd8_5a8c7b7b
PS2, Line 7: soc/intel/alderlake: Configure 9 I/O for ADL-N
Please clarify number 9. […]
Ack
https://review.coreboot.org/c/coreboot/+/59752/comment/75e1ef56_e0ceebfe
PS2, Line 9: Select number of I/O based on PCH for Alder Lake-N
Please elaborate the changes like what are different port supported such as 9 PCIe root ports, 5 Clk […]
Ack
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/59752/comment/d8f38461_6f0d9781
PS2, Line 177: default
Please take a look into this […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59752
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ebbcdcdb1ccc34b80ec71ac3e591fe4ad6b1904
Gerrit-Change-Number: 59752
Gerrit-PatchSet: 4
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Kangheui Won
khwon@google.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 07:30:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment