Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 )
Change subject: src/mainboard/libretrend/lt1000: Initial commit ......................................................................
Patch Set 13:
(6 comments)
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/Kconfig:
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... PS13, Line 11: select MAINBOARD_HAS_LPC_TPM : select INTEL_GMA_HAVE_VBT : select MAINBOARD_HAS_LIBGFXINIT any reason not to alphabetize these?
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/acpi/ec.asl:
PS13: can be dropped?
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/acpi_tables.c:
PS13: pretty sure this can be dropped
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/bootblock.c:
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... PS13, Line 38: devictree devicetree
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... PS13, Line 41: devictree here too
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/mainboard.c:
PS13: this can be dropped/replaced by selection of DRIVERS_GENERIC_CBFS_SERIAL in Kconfig
-
Matt DeVillier (Code Review)