Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41166 )
Change subject: mb/google/volteer: early audio subsystem selection ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41166/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/cbi.c:
https://review.coreboot.org/c/coreboot/+/41166/1/src/mainboard/google/voltee... PS1, Line 11: MAYBE_STATIC_BSS int fw_initialized = 0; : MAYBE_STATIC_BSS uint32_t fw_config; MAYBE_STATIC_BSS has been converted to just 'static' (see CB:40535)
https://review.coreboot.org/c/coreboot/+/41166/1/src/mainboard/google/voltee... PS1, Line 22: fw_initialized = 1; nit: blank line after if statement
https://review.coreboot.org/c/coreboot/+/41166/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/audio.h:
https://review.coreboot.org/c/coreboot/+/41166/1/src/mainboard/google/voltee... PS1, Line 7: #include <stdint.h> unused in this file
-
Tim Wawrzynczak (Code Review)