Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Matt DeVillier, Michał Żygowski, Nick Vaccaro, Sean Rhodes, Subrata Banik.
Paul Menzel has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84622?usp=email )
Change subject: soc/intel/alderlake: Change the maximum C state to C8
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84622/comment/e7c6cbf7_b45635be?usp... :
PS6, Line 13: Tested on `starbook_adl` with Ubuntu 24.04 by booting, and
: performing multiple S3 cycles.
It is reached
Also before, or only with your patch? It’d be great if you mentioned it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84622?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb3e4d34361c8ac25ef144c0d1cda9f801ed0c54
Gerrit-Change-Number: 84622
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 21 Jan 2025 09:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org